From de7ede02dacc87e7eb8401dd5e8dbd337f2488a1 Mon Sep 17 00:00:00 2001
From: Danny Ben Shitrit <db@dannyben.com>
Date: Mon, 28 Nov 2022 14:24:40 +0000
Subject: [PATCH 1/2] - Show warning when running the test command on an
 invalid file

---
 lib/completely/commands/test.rb       |  9 ++++++---
 spec/completely/commands/test_spec.rb | 13 +++++++++++++
 2 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/lib/completely/commands/test.rb b/lib/completely/commands/test.rb
index 9493317..ebdd006 100644
--- a/lib/completely/commands/test.rb
+++ b/lib/completely/commands/test.rb
@@ -22,10 +22,13 @@ class Test < Base
 
       def run
         puts tester.test(compline).join "\n"
-        return unless args['--keep']
 
-        File.write 'completely-tester.sh', tester_script
-        puts 'saved completely-tester.sh'
+        if args['--keep']
+          File.write 'completely-tester.sh', tester_script
+          puts 'saved completely-tester.sh'
+        end
+
+        syntax_warning unless completions.valid?
       end
 
     private
diff --git a/spec/completely/commands/test_spec.rb b/spec/completely/commands/test_spec.rb
index 672bea7..084b496 100644
--- a/spec/completely/commands/test_spec.rb
+++ b/spec/completely/commands/test_spec.rb
@@ -65,4 +65,17 @@
         .to raise_approval('cli/test/error')
     end
   end
+
+  context 'with an invalid configuration' do
+    before do
+      reset_tmp_dir
+      File.write 'spec/tmp/in.yaml', { 'one' => %w[anything], 'two' => %w[something] }.to_yaml
+      ENV['COMPLETELY_CONFIG_PATH'] = 'spec/tmp/in.yaml'
+    end
+
+    it 'outputs a warning to STDERR' do
+      expect { subject.execute %w[test on] }
+        .to output_approval('cli/warning').to_stderr
+    end
+  end
 end

From 928d231e3605a56820605e8f3f5e0c0cde92ff5c Mon Sep 17 00:00:00 2001
From: Danny Ben Shitrit <db@dannyben.com>
Date: Mon, 28 Nov 2022 14:25:56 +0000
Subject: [PATCH 2/2] compact unnecessary newline

---
 spec/completely/commands/test_spec.rb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/spec/completely/commands/test_spec.rb b/spec/completely/commands/test_spec.rb
index 084b496..87f82a0 100644
--- a/spec/completely/commands/test_spec.rb
+++ b/spec/completely/commands/test_spec.rb
@@ -74,8 +74,7 @@
     end
 
     it 'outputs a warning to STDERR' do
-      expect { subject.execute %w[test on] }
-        .to output_approval('cli/warning').to_stderr
+      expect { subject.execute %w[test on] }.to output_approval('cli/warning').to_stderr
     end
   end
 end