Add a Makefile target for pulse tests #124

Merged
merged 3 commits into from Dec 12, 2013

Conversation

Projects
None yet
3 participants
@kellymclaughlin
Contributor

kellymclaughlin commented Nov 22, 2013

Add a Makefile target to run the pulse tests. The goal is to make it as simple
as possible to run these tests in order to increase the likelihood they are
run during the normal course of code reviews and not simply forgotten. The
pulse test modules are moved up directly into the test directory to allow
rebar to find them and the test module is renamed to bitcask_pulse for easier
identification. Also a new version of rebar that can properly execute the new
Makefile target is added.

@evanmcc

This comment has been minimized.

Show comment
Hide comment
@evanmcc

evanmcc Dec 9, 2013

Contributor

Does this change the need to uncomment all the stuff in the rebar.config?

Contributor

evanmcc commented Dec 9, 2013

Does this change the need to uncomment all the stuff in the rebar.config?

@kellymclaughlin

This comment has been minimized.

Show comment
Hide comment
@kellymclaughlin

kellymclaughlin Dec 10, 2013

Contributor

No, but I think I can fix that as well.

Contributor

kellymclaughlin commented Dec 10, 2013

No, but I think I can fix that as well.

kellymclaughlin added some commits Nov 22, 2013

Add a Makefile target for pulse tests
Add a Makefile target to run the pulse tests. The goal is to make it
as simple as possible to run these tests in order to increase the
likelihood they are run during the normal course of code reviews and
not simply forgotten. The pulse test modules are moved up directly
into the test directory to allow rebar to find them and the test
module is renamed to bitcask_pulse for easier identification.  Also a
new version of rebar that can properly execute the new Makefile target
is added.
@kellymclaughlin

This comment has been minimized.

Show comment
Hide comment
@kellymclaughlin

kellymclaughlin Dec 10, 2013

Contributor

Added a rebar.config.script to handle the setup for building and running the pulse tests. I also rebased the branch from develop to pull in Scott's recent changes to the pulse test.

Contributor

kellymclaughlin commented Dec 10, 2013

Added a rebar.config.script to handle the setup for building and running the pulse tests. I also rebased the branch from develop to pull in Scott's recent changes to the pulse test.

@evanmcc

This comment has been minimized.

Show comment
Hide comment
@evanmcc

evanmcc Dec 10, 2013

Contributor

looks good to me. @slfritchie, any opinions/objections?

Contributor

evanmcc commented Dec 10, 2013

looks good to me. @slfritchie, any opinions/objections?

slfritchie added a commit that referenced this pull request Dec 12, 2013

@slfritchie slfritchie merged commit 1db995d into develop Dec 12, 2013

1 check was pending

default The Travis CI build is in progress
Details
@slfritchie

This comment has been minimized.

Show comment
Hide comment
@slfritchie

slfritchie Dec 12, 2013

Contributor

Many thanks, Kelly, that was a great idea!

Contributor

slfritchie commented Dec 12, 2013

Many thanks, Kelly, that was a great idea!

@seancribbs seancribbs deleted the feature/pulse-makefile-target branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment