Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Rename/refactor a bunch of cuttlefish settings. #127

merged 2 commits into from Dec 26, 2013


None yet
2 participants

seancribbs commented Dec 14, 2013

Also improved the docs and employed the @see option for multi_backend settings. For details about the changes, see f1dcf6e.

J4/CV/JD/SC and others added some commits Dec 13, 2013

@seancribbs J4/CV/JD/SC + seancribbs [confbal] Rename and redesign a bunch of cuttlefish settings, improve…
… docs.

* Setting name is removed from all docstrings. The name can be
  generated from the schema and will be displayed when using the
  "describe" cuttlefish command.
* sync_strategy -> sync.strategy; sync_interval -> sync.interval
* merge_window -> merge.policy -- There is no window if set to
  'always' or 'never', so "policy" seems a better name.
* merge_window.start/end -> merge.window.start/end
* frag_merge_trigger -> merge.triggers.fragmentation (more
  descriptive). The "is_percentage" validator was also added to
  constrain the values.
* dead_bytes_merge_trigger -> merge.triggers.dead_bytes (similar to
* frag_threshold -> thresholds.fragmentation (again adding
  "is_percentage" validator)
* dead_bytes_threshold -> thresholds.dead_bytes
* small_file_threshold -> thresholds.small_file
* max_fold_age -> fold.max_age. Added the possible value of
  `unlimited` (replaces -1 magic value) as well as a duration in
  milliseconds. The input value is upscaled to microseconds, but we
  have no evidence of anyone setting this setting. Probably best to
  change it in advanced.config.
* max_fold_puts -> fold.max_puts. Added value of `unlimited` which
  replaces the magic value of -1.
* Added `off` to expiry, which disables the feature (instead of the -1
  magic value).
* require_hint_crc -> hintfile_checksums. Changed settings to `strict`
  and `allow_missing` instead of true/false.
* expiry_grace_time -> expiry.grace_time
* multi_backend settings were converted to use @see tags instead of
  copying the docstrings.
@seancribbs seancribbs Update schema tests for renamed settings. 348a13e

slfritchie commented Dec 26, 2013

Hi, all. Sorry I overlooked this PR during this week's merge madness. Looks nice, and doesn't appear to upset any existing riak_test scripts, as far as I can tell from today's 'master' r_t repo. +1, I'll merge it, thanks!

@slfritchie slfritchie added a commit that referenced this pull request Dec 26, 2013

@slfritchie slfritchie Merge pull request #127 from basho/refactor/confbal/schema-renames
Rename/refactor a bunch of cuttlefish settings.

@slfritchie slfritchie merged commit a00bfd8 into develop Dec 26, 2013

1 check failed

default The Travis CI build failed

@seancribbs seancribbs deleted the refactor/confbal/schema-renames branch Jan 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment