New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid hintfile error message is too severe #164
Merged
borshop
merged 2 commits into
develop
from
feature/invalid-hintfile-error-message-level
Apr 17, 2014
Merged
Invalid hintfile error message is too severe #164
borshop
merged 2 commits into
develop
from
feature/invalid-hintfile-error-message-level
Apr 17, 2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+1 |
This is a trivial change, if someone wants to PR it, I would be OK with it going in before RC. |
I'll grab this. |
Fixes #164 This is not uncommon, and is not cause for alarm, so we shouldn't scare users with an 'error' level log message.
Attached a commit to this issue. |
Good catch. I'll add those momentarily. |
See previous commit for more detail.
pooshed |
+1 08c873c |
borshop
added a commit
that referenced
this pull request
Apr 16, 2014
…sage-level Invalid hintfile error message is too severe Reviewed-by: evanmcc
@borshop retry |
Aha, looks like it was wanting a ':' in the message. |
borshop
added a commit
that referenced
this pull request
Apr 17, 2014
…sage-level Invalid hintfile error message is too severe Reviewed-by: evanmcc
@borshop: merge |
borshop
added a commit
that referenced
this pull request
Apr 17, 2014
…sage-level Invalid hintfile error message is too severe Reviewed-by: evanmcc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid hintfiles happen all the time and it's ok. We should use warning or notice for: