Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upErlang 18.0 now() fix. #221
Open
Conversation
Temporarily depend on {branch, "develop"} of cuttlefish.
|
Hi, Bill, sorry about the delay, we at Basho have been bad recently about handling outside PRs for some of our repos. This PR will take a lot of time to review, for the same reasons that a similar riak_core PR is delayed. Please see the discussion at basho/riak_core#785 (comment) and following. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
billstclair commentedSep 24, 2015
Make bitcask work in OTP 18.0.
The rebar.config change temporarily depends on {branch, "develop"} of cuttlefish. When it's merged, it should really depend on a new tag on cuttlefish. I need the OTP 18 changes there that are newer than any current tag.
This fixes the OTP 18 deprecation warnings for erlang:now(), which are fatal due to warnings_as_errors in the erl_opts setting in rebar.config.
The bitcask_timestamp.erl code is from http://www.erlang.org/doc/apps/erts/time_compat.erl
The modified bitcask application passes "make test" in basho/otp branches basho-otp-16, basho-otp-17, and basho-otp-18. "All 81 tests passed."