Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adds "grace period" to stop just-written files from expiring. #54

Merged
merged 6 commits into from Sep 13, 2012

Conversation

Projects
None yet
2 participants
Contributor

chardan commented Sep 7, 2012

No description provided.

@ghost ghost assigned chardan and reiddraper Sep 10, 2012

@reiddraper reiddraper commented on an outdated diff Sep 13, 2012

test/bitcask_qc_expiry.erl
@@ -32,6 +32,17 @@
-define(QC_OUT(P),
eqc:on_output(fun(Str, Args) -> io:format(user, Str, Args) end, P)).
+%% JFW
@reiddraper

reiddraper Sep 13, 2012

Contributor

not sure if we need the initials, git blame can do that

Contributor

reiddraper commented Sep 13, 2012

Some documentation for this change would be nice, but the code looks good. I tested by taking a situation that previously caused merges every 10s, and then used the new code with expiry_grace_time, 60. It worked as expected, I merges only occured once every 60s.

Contributor

reiddraper commented Sep 13, 2012

+1 to merge

chardan added a commit that referenced this pull request Sep 13, 2012

Merge pull request #54 from basho/jfw-br-grace_timeout
Adds "grace period" to stop just-written files from expiring.

@chardan chardan merged commit aab96ac into master Sep 13, 2012

1 check passed

default The Travis build passed
Details

@engelsanchez engelsanchez deleted the jfw-br-grace_timeout branch Mar 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment