Clear all Dialyzer warnings #70

merged 2 commits into from Nov 16, 2012


None yet

2 participants


Fixes #63.


slfritchie added some commits Nov 16, 2012
@slfritchie slfritchie Minimal changes to get zero Dialyzer warnings
Nice to see that Dialyzer caught a bug from parallel development,
adding the is_empty_estimate/1 function, and today's merge of
the new QuickCheck model.
@slfritchie slfritchie Remove type inference cruft 8dc6f34
@slfritchie slfritchie was assigned Nov 16, 2012
jrwest commented Nov 16, 2012

ran dialyzer on this branch and all looks good. Changes look good to me. I'm not super familiar with the erlang:random vs. erlang:nif_error usage in the nif placeholder funs so perhaps there is something subtle there i am not aware of.

tl;dr +1 but perhaps a second quick review would be good since I'm still getting familiar w/ the bitcask source.

@slfritchie slfritchie merged commit f706bad into master Nov 16, 2012

1 check failed

Details default The Travis build failed
@engelsanchez engelsanchez deleted the slf-dialyzer20121116 branch Mar 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment