Ignore errors from file close, move to terminate #75

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

engelsanchez commented Dec 27, 2012

Found a problem in the partition repair test where file close might
return {error, badarg} instead of ok, possibly for being called too
early before the file was actually open. This is a nicety anyway as the
VM should close the file if the owner process dies.

@slfritchie this ok?

Ignore errors from file close, move to terminate
Found a problem in the partition repair test where file close might
return {error, badarg} instead of ok, possibly for being called too
early before the file was actually open. This is a nicety anyway as the
VM should close the file if the owner process dies.
Contributor

slfritchie commented Dec 28, 2012

Engel, last I recall yesterday, there were still tests failing as a result of this patch. Was that a test problem or a real problem caused by this patch?

Contributor

engelsanchez commented Dec 29, 2012

The errors are still there. I tried this patch, then another with a suggestion from Andrew Thompson to double sync and double close the file on terminate (which still seems to be a good idea, will update this with that). But I'm still ending up with corrupt bitcask files. I'll ping you later about my plans to track it down.

Contributor

engelsanchez commented Feb 4, 2013

This was a dead end and the corruption was tracked down and addressed in basho/riak_core#264.

@seancribbs seancribbs deleted the eas-ignore-file-close-err branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment