eunit test enhancements. #84

Merged
merged 2 commits into from Apr 4, 2013

Conversation

Projects
None yet
4 participants
Contributor

evanmcc commented Mar 19, 2013

Alter the unit tests to be callable from the makefile and for the
defaults to call the unit tests twice, once for each io_mode.

@seancribbs is there a way to tell travis to use 'make eunit' rather than its current direct rebar call? I looked at the .travis.yml but it didn't contain a lot of information.

Alter the unit tests to be callable from the makefile and for the
defaults to call the unit tests twice, once for each io_mode.

@ghost ghost assigned evanmcc Mar 19, 2013

Contributor

seancribbs commented Mar 20, 2013

FWIW I think make test is the convention on our other projects.

Contributor

evanmcc commented Mar 20, 2013

updated, both checks are being run on travis with this change.

@ghost ghost assigned engelsanchez Apr 3, 2013

Contributor

engelsanchez commented Apr 4, 2013

The code looks good. I ran the tests locally and verified each target only runs in that io mode by inserting throws in the code. Sean's concern was addressed and it is obviously running in Travis now. 👍 💃

evanmcc added a commit that referenced this pull request Apr 4, 2013

@evanmcc evanmcc merged commit 83ec5b4 into master Apr 4, 2013

1 check passed

default The Travis build passed
Details

@ghost ghost assigned evanmcc Apr 4, 2013

qzjian commented Apr 5, 2013

I am glad it's useful to you

------------------ 原始邮件 ------------------
发件人: "Engel Sanchez"notifications@github.com;
发送时间: 2013年4月4日(星期四) 晚上10:26
收件人: "basho/bitcask"bitcask@noreply.github.com;

主题: Re: [bitcask] eunit test enhancements. (#84)

The code looks good. I ran the tests locally and verified each target only runs in that io mode by inserting throws in the code. Sean's concern was addressed and it is obviously running in Travis now.


Reply to this email directly or view it on GitHub.

@engelsanchez engelsanchez deleted the pevm-io-mode-tests branch Mar 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment