Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return/report/warnings_as_errors compile options [JIRA: RIAK-2281] #16

Closed
ghost opened this issue May 31, 2012 · 3 comments
Closed

Comments

@ghost
Copy link

ghost commented May 31, 2012

It would be highly useful to add the same return/return_warnings/return_errors/report/report_warnings/report_errors/warnings_as_errors options as available in compile:file and leex:file for erlang_protobuffs' own errors/warnings.

@lordnull
Copy link
Contributor

This is already done:

protobuffs_compile:scan_file("messages.proto", [{compile_flags, [warnings_as_errors]}]).

These are passed to the call to compile:file/2 with 'report' prepended. What needs to happen is actual documentation of the options.

@ghost
Copy link
Author

ghost commented Oct 10, 2014

@lordnull, does that mean erlang_protobuffs doesn't emit warnings of its own? Options passed to compile:file of course support warnings_as_errors, but the ticket is about warnings emitted by this compiler.

@lukebakken
Copy link
Contributor

A PR with this feature and tests would be appreciated. If one is submitted, please reference this issue and re-open it. Thank you.

@Basho-JIRA Basho-JIRA changed the title Add return/report/warnings_as_errors compile options Add return/report/warnings_as_errors compile options [JIRA: RIAK-2281] Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants