Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Cleanup warnings #42

Merged
merged 6 commits into from Mar 14, 2013

Conversation

Projects
None yet
3 participants
Contributor

seancribbs commented Mar 7, 2013

  1. The warn_missing_spec flag is obnoxious, and overkill when we properly dialyze. Removed.
  2. Removed a bunch of miscellaneous warnings about unused variables, functions, and shadowed variables.
  3. Added dialyzer to the Makefile.
  4. Fixed several dialyzer warnings.

seancribbs added some commits Mar 7, 2013

Fix dialyzer warnings.
Fixed:
pokemon_pb.erl:52: The pattern <Default, _> can never match since previous clauses completely covered the type <_,'none'>
pokemon_pb.erl:53: The pattern <Val, _> can never match since previous clauses completely covered the type <_,'none'>
protobuffs.erl:373: Invalid type specification for function protobuffs:encode_field_tag/2. The success typing is (non_neg_integer(),0 | 1 | 2 | 5) -> [integer(),...]
protobuffs.erl:387: Invalid type specification for function protobuffs:encode_varint/1. The success typing is (integer()) -> [integer(),...]
protobuffs.erl:393: Invalid type specification for function protobuffs:encode_varint/2. The success typing is (integer(),[integer()]) -> [integer(),...]

Safe to ignore:
pokemon_pb.erl:46: The variable _ can never match since previous clauses completely covered the type #pikachu{}

@ghost ghost assigned seancribbs and russelldb Mar 13, 2013

@russelldb russelldb commented on the diff Mar 14, 2013

src/protobuffs.erl
@@ -26,7 +26,7 @@
%% @doc A protcol buffers encoding and decoding module.
-module(protobuffs).
-%% Pubic
Member

russelldb commented Mar 14, 2013

Ran dialyzer on this (there are still warnings) and master (there are many more warnings). All the changes make sense and things work as expected. +1 from me

seancribbs added a commit that referenced this pull request Mar 14, 2013

@seancribbs seancribbs merged commit cbe7ee0 into master Mar 14, 2013

1 check passed

default The Travis build passed
Details

@seancribbs seancribbs deleted the sdc-cleanup-warnings branch Mar 14, 2013

@ghost ghost assigned seancribbs Mar 14, 2013

d11wtq commented Apr 10, 2013

I just installed riak-erlang-client (latest tag 1.3.1.1) and got a terminal screen sprayed full of warnings from (I assume) this :) Looking at the tags, the last release was 2 months ago. Is there any plan to release an update?

Contributor

seancribbs commented Apr 10, 2013

@d11wtq Yes, there will be an update soon, probably around the time of the 1.4 release.

d11wtq commented Apr 11, 2013

Awesome, thanks.

@seancribbs seancribbs removed their assignment May 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment