Cleanup warnings #42

Merged
merged 6 commits into from Mar 14, 2013

Projects

None yet

3 participants

@seancribbs
Contributor
  1. The warn_missing_spec flag is obnoxious, and overkill when we properly dialyze. Removed.
  2. Removed a bunch of miscellaneous warnings about unused variables, functions, and shadowed variables.
  3. Added dialyzer to the Makefile.
  4. Fixed several dialyzer warnings.
seancribbs added some commits Mar 7, 2013
@seancribbs seancribbs Remove warnings about lacking specs. 4254864
@seancribbs seancribbs Address warnings about unused variables and functions. 9ade643
@seancribbs seancribbs Add dialyzer makefile targets. d732191
@seancribbs seancribbs Fix dialyzer warnings.
Fixed:
pokemon_pb.erl:52: The pattern <Default, _> can never match since previous clauses completely covered the type <_,'none'>
pokemon_pb.erl:53: The pattern <Val, _> can never match since previous clauses completely covered the type <_,'none'>
protobuffs.erl:373: Invalid type specification for function protobuffs:encode_field_tag/2. The success typing is (non_neg_integer(),0 | 1 | 2 | 5) -> [integer(),...]
protobuffs.erl:387: Invalid type specification for function protobuffs:encode_varint/1. The success typing is (integer()) -> [integer(),...]
protobuffs.erl:393: Invalid type specification for function protobuffs:encode_varint/2. The success typing is (integer(),[integer()]) -> [integer(),...]

Safe to ignore:
pokemon_pb.erl:46: The variable _ can never match since previous clauses completely covered the type #pikachu{}
7c3612c
@seancribbs seancribbs Remove commented-out code. 078af4d
@seancribbs seancribbs Remove more commented-out code. 4352fef
@russelldb russelldb commented on the diff Mar 14, 2013
src/protobuffs.erl
@@ -26,7 +26,7 @@
%% @doc A protcol buffers encoding and decoding module.
-module(protobuffs).
-%% Pubic
@russelldb

Ran dialyzer on this (there are still warnings) and master (there are many more warnings). All the changes make sense and things work as expected. +1 from me

@seancribbs seancribbs merged commit cbe7ee0 into master Mar 14, 2013

1 check passed

default The Travis build passed
Details
@seancribbs seancribbs deleted the sdc-cleanup-warnings branch Mar 14, 2013
@seancribbs seancribbs was assigned Mar 14, 2013
@d11wtq
d11wtq commented Apr 10, 2013

I just installed riak-erlang-client (latest tag 1.3.1.1) and got a terminal screen sprayed full of warnings from (I assume) this :) Looking at the tags, the last release was 2 months ago. Is there any plan to release an update?

@seancribbs
Contributor

@d11wtq Yes, there will be an update soon, probably around the time of the 1.4 release.

@d11wtq
d11wtq commented Apr 11, 2013

Awesome, thanks.

@seancribbs seancribbs removed their assignment May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment