Add server sent events. #32

Merged
merged 4 commits into from Jan 7, 2013

Conversation

Projects
None yet
3 participants
@cmeiklejohn
Contributor

cmeiklejohn commented Dec 6, 2012

@seancribbs

Obsoletes #31.

@seancribbs

This comment has been minimized.

Show comment Hide comment
@seancribbs

seancribbs Dec 24, 2012

Let's redo this now that #38 is completed and ready for review.

Let's redo this now that #38 is completed and ready for review.

@cmeiklejohn

This comment has been minimized.

Show comment Hide comment
@cmeiklejohn

cmeiklejohn Dec 29, 2012

Contributor

Rebased against master.

Contributor

cmeiklejohn commented Dec 29, 2012

Rebased against master.

@seancribbs

This comment has been minimized.

Show comment Hide comment
@seancribbs

seancribbs Dec 29, 2012

It might be nice to have some indication in the UI that a new item was received, like an alert or something?

It might be nice to have some indication in the UI that a new item was received, like an alert or something?

@seancribbs

This comment has been minimized.

Show comment Hide comment
@seancribbs

seancribbs Dec 30, 2012

We should also get on Revision 11 of data, given the changes from this week. https://github.com/emberjs/data/blob/master/BREAKING_CHANGES.md

We should also get on Revision 11 of data, given the changes from this week. https://github.com/emberjs/data/blob/master/BREAKING_CHANGES.md

@cmeiklejohn

This comment has been minimized.

Show comment Hide comment
@cmeiklejohn

cmeiklejohn Jan 4, 2013

Contributor

When you say alert, I really want to put an alert(); in. 🐟

Contributor

cmeiklejohn commented Jan 4, 2013

When you say alert, I really want to put an alert(); in. 🐟

@cmeiklejohn

This comment has been minimized.

Show comment Hide comment
@cmeiklejohn

cmeiklejohn Jan 4, 2013

Contributor

I'm going to do the revision 11 upgrade later as it requires an ember bump which breaks a large amount of the application.

Contributor

cmeiklejohn commented Jan 4, 2013

I'm going to do the revision 11 upgrade later as it requires an ember bump which breaks a large amount of the application.

@cmeiklejohn

This comment has been minimized.

Show comment Hide comment
@cmeiklejohn

cmeiklejohn Jan 4, 2013

Contributor

@joedevivo

You have to click a link to be prompted, but then you'll have webkit notifications for any new results being posted to GiddyUp.

If you ask me, not bad, for a human.

Contributor

cmeiklejohn commented Jan 4, 2013

@joedevivo

You have to click a link to be prompted, but then you'll have webkit notifications for any new results being posted to GiddyUp.

If you ask me, not bad, for a human.

@cmeiklejohn

This comment has been minimized.

Show comment Hide comment
@cmeiklejohn

cmeiklejohn Jan 4, 2013

Contributor

Screen Shot 2013-01-04 at 5 36 19 PM

Contributor

cmeiklejohn commented Jan 4, 2013

Screen Shot 2013-01-04 at 5 36 19 PM

@joedevivo

This comment has been minimized.

Show comment Hide comment
@joedevivo

joedevivo Jan 4, 2013

That's hot.

That's hot.

@joedevivo

This comment has been minimized.

Show comment Hide comment
@joedevivo

joedevivo Jan 7, 2013

looks and works great. Can we add more information to the alert?

something like

GiddyUp: New ${Pass|Fail} on ${ScorecardShortName}
hostname
$Testname | $Backend | $Platform
$HudsonQuote

looks and works great. Can we add more information to the alert?

something like

GiddyUp: New ${Pass|Fail} on ${ScorecardShortName}
hostname
$Testname | $Backend | $Platform
$HudsonQuote

@cmeiklejohn

This comment has been minimized.

Show comment Hide comment
@cmeiklejohn

cmeiklejohn Jan 7, 2013

Contributor

"On it." - Hudson

Contributor

cmeiklejohn commented Jan 7, 2013

"On it." - Hudson

@joedevivo

This comment has been minimized.

Show comment Hide comment
@joedevivo

joedevivo Jan 7, 2013

+1 for phat new alerts

+1 for phat new alerts

cmeiklejohn added a commit that referenced this pull request Jan 7, 2013

@cmeiklejohn cmeiklejohn merged commit f6223fe into master Jan 7, 2013

@cmeiklejohn cmeiklejohn deleted the csm-server-sent-events-rebased branch Jan 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment