Clean up, and ensure we always load record into RA. #40

Merged
merged 1 commit into from Jan 9, 2013

Projects

None yet

3 participants

@cmeiklejohn
Contributor

This fixes a problem with SSE where a record doesn't show up if the association record-array already exists with a fixed set of identifiers.

@cmeiklejohn
Contributor

@seancribbs I think this addresses the results not showing up. I also can not reproduce the 'live' error locally at all, but it shouldn't be a problem because it will reconnect every 2 seconds per the spec.

@cmeiklejohn
Contributor

Tagging @joedevivo for review if he has time. Way to test: local up the scorecard, run a test and the bubble should colorize (or if you are viewing a test instance, you'll see a result added to the list.)

@joedevivo joedevivo was assigned Jan 8, 2013
@seancribbs

WFM now, no errors in the logs and I get the desktop notifications like a champ. I might be missing some image because I got a "broken image" icon next to the notification.

@cmeiklejohn
Contributor

:)

@cmeiklejohn
Contributor

OK to merge?

@seancribbs

not bad for a human

Ready to merge.

@cmeiklejohn
Contributor

lolololololo glad you caught up on meme innovation while you were gone

@cmeiklejohn cmeiklejohn merged commit fc24391 into master Jan 9, 2013
@cmeiklejohn
Contributor

Merged && deployed.

@cmeiklejohn cmeiklejohn deleted the csm-fix-record-array-access branch Jan 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment