Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Remove erl_opts from rebar.config #96

Closed
wants to merge 1 commit into from

3 participants

@aleksandr-vin

Parameter erl_opts must be ignored for the dependee projects when
committing. Because its presence here discards the value of the
depender's option while it must be used for compile-time selection of
the dependee configuration, the decision being made by the depender.

@aleksandr-vin aleksandr-vin Remove erl_opts from rebar.config
Parameter erl_opts must be ignored for the dependee projects when
committing. Because its presence here discards the value of the
depender's option while it must be used for compile-time selection of
the dependee configuration, the decision being made by the depender.
bb6d307
@Vagabond
Collaborator

I'm sorry, but I don't understand the commit message. What problem does this solve, exactly?

@aleksandr-vin

It solves the problem of blocking the inheritance of the depender's erl_opts value.

When for ex. I depend my project A from the project B (lager for instance), and I want to compile project A + all the deps with say ['debug_info', {d, 'SOME_OPT'}]: I set it in A/rebar.config and B project inherits its value.

But if there is already an erl_opts in B/rebar.config, then the inheritance will fail.

@seancribbs

I would be :-1: on this, the debug_info flag is needed by dialyzer. If @aleksandr-vin's problem is to be solved, it is a rebar problem, not lager.

@Vagabond
Collaborator

Yes, rebar should have a fix for this issue, not lager.

@Vagabond Vagabond closed this
@aleksandr-vin

Ok, sounds right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 1, 2012
  1. @aleksandr-vin

    Remove erl_opts from rebar.config

    aleksandr-vin authored
    Parameter erl_opts must be ignored for the dependee projects when
    committing. Because its presence here discards the value of the
    depender's option while it must be used for compile-time selection of
    the dependee configuration, the decision being made by the depender.
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 1 deletion.
  1. +0 −1  rebar.config
View
1  rebar.config
@@ -1,4 +1,3 @@
-{erl_opts, [debug_info]}.
{erl_first_files, ["src/lager_util.erl"]}.
{cover_enabled, true}.
Something went wrong with that request. Please try again.