Fix w.done code path in DBImpl::Write() #85

Closed
matthewvon opened this Issue Jun 25, 2013 · 1 comment

Comments

Projects
None yet
1 participant
@matthewvon
Contributor

matthewvon commented Jun 25, 2013

Agreement out of code review was that the code path of

if (w.done)
return w.status;

needs to be updated to flow through the throttle at the bottom of the function to maintain proper throttle participation. The change was not made today due to the lateness of the release cycle.

@matthewvon

This comment has been minimized.

Show comment Hide comment
@matthewvon

matthewvon Dec 1, 2013

Contributor

Recent update to DBImpl::Write() includes logic to now throttle based upon number of items in a batch (except batches created against internal databases, i.e. active anti-entropy). So the code path still exits, but the throttle time is now properly accounted since this call's contents had be merged into a prior batch. The throttle wait occurred in the prior batch.

Contributor

matthewvon commented Dec 1, 2013

Recent update to DBImpl::Write() includes logic to now throttle based upon number of items in a batch (except batches created against internal databases, i.e. active anti-entropy). So the code path still exits, but the throttle time is now properly accounted since this call's contents had be merged into a prior batch. The throttle wait occurred in the prior batch.

@matthewvon matthewvon closed this Dec 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment