Skip to content
Commits on Apr 2, 2012
  1. @devinus
Commits on Mar 22, 2012
  1. @devinus

    Bump the version

    devinus committed
  2. @devinus

    Add poolboy_worker behaviour

    devinus committed
  3. @devinus

    Upgrade rebar

    devinus committed
  4. @devinus
  5. @devinus

    Convert some tabs to spaces

    devinus committed
Commits on Jan 31, 2012
  1. Upgrade rebar

    Devin Torres committed
  2. Add more targets to .PHONY in Makefile and add get-deps for when we a…

    Devin Torres committed
    …dd PropEr
  3. Sorry Kurt

    Devin Torres committed
  4. @devinus

    Merge pull request #8 from basho/adt-more-quickcheck-fixes

    devinus committed
    Fix bug with incorrect pid in monitor list
  5. @Vagabond

    Fix issue where the wrong pid was being stored in the list of monitors

    Vagabond committed
    When a pid exited while the pool was full and there were blocking
    checkouts, poolboy would put the pid of the process requesting a worker
    in the monitor tuple along with the monitor ref, instead of the pid of
    the worker.
  6. @Vagabond
Commits on Jan 27, 2012
  1. Simple cleanup & bump the version to 0.6

    Devin Torres committed
Commits on Jan 26, 2012
  1. Merge pull request #7 from basho/adt-quickcheck

    Devin Torres committed
    QuickCheck Poolboy
Commits on Jan 22, 2012
  1. @Vagabond

    Add a parallel property for poolboy

    Vagabond committed
    To trigger some of the more interesting code, we need to truly do things
    in parallel, so blocking checkouts can actually happen while other
    requests are being made. This commit adds a parallel property for
    poolboy, based on the original serial one.
    
    One hack that was needed was to add a trailing call to erlang:self() to
    the end of each parallel branch so that we could filter out workers
    checked out by that particular branch from the model. This is necessary
    because poolboy monitors the process holding the worker and will destroy
    any workers held by a process and re-start them, if necessary, to
    maintain the right number of workers in the pool. This filtering is done
    in the next_state command, and all elements in the checked_out list in
    the model are tuples of {Worker, self()} so the list can be filtered.
    
    Happily, although this exercises more core, no additional bugs were
    found.
  2. @Vagabond

    Checkin non-worker processes 10% of the time and fix resulting bugs

    Vagabond committed
    Checking in an invalid process corrupts the internal state similarly to
    receiving EXITs from non-worker pids.
  3. @Vagabond

    Add command to send poolboy EXIT messages for unrelated pids; fix bugs

    Vagabond committed
    Sending poolboy EXIT messages for pids that are not workers causes
    invalid changes to poolboy's state. Also, legitimate processes dying
    after being checked back in also would corrupt the internal state. Add
    better checking in the EXIT handling code to guard against this.
  4. @Vagabond

    Add command to kill workers after they're checked back in, and fix bugs

    Vagabond committed
    Extend the 'status' to check the number of monitors poolboy has on
    processes that have checked out workers. When a process dies after being
    checked back in, poolboy zeroes out the list of monitors for some reason.
  5. @Vagabond

    Add kill_worker and fix resulting bugs

    Vagabond committed
    kill_worker exposed some new faults in poolboy, where the maximum size
    of the pool could end up smaller than it should be after a worker was
    killed.
    
    To help in debugging this, a 'status' command was added to poolboy to
    look at its internal state and a dynamic_precondition function was used
    to compare the expected state to the actual state.
    
    Numerous problems were discovered by doing this, poolboy had issues
    around when it changed states, like allocating the last non-overflow
    worker would leave the pool in 'ready' until the next request came in,
    instead of immediately changing the state.
Commits on Jan 21, 2012
  1. @Vagabond

    Add blocking checkout to quickcheck test and fix poolboy bug

    Vagabond committed
    The bug discovered was that blocking checkouts that had expired were not
    being removed from the list of 'waiting' checkouts, so when a checkout
    had timed out and a worker was subsequently checked in, the new worker
    would be sent to the expired checkout request, not any current ones.
  2. @Vagabond

    Initial quickcheck test for poolboy

    Vagabond committed
    For now, only test the simplest API; start, stop, checkout nonblocking
    and checkin.
Commits on Jan 5, 2012
  1. @Vagabond
Commits on Dec 29, 2011
Commits on Dec 27, 2011
  1. Fix typespec for checkout

    Devin Torres committed
Commits on Nov 29, 2011
  1. Meh, that didn't work

    Devin Torres committed
  2. Link to GH profiles from authors

    Devin Torres committed
  3. Change example supervisor strategy to one_for_one

    Devin Torres committed
Commits on Nov 18, 2011
  1. Merge pull request #6 from kevsmith/init_fun

    Devin Torres committed
    Added init and stop funs to poolboy's config
Commits on Nov 10, 2011
  1. Added init and stop funs to poolboy's config

    Kevin Smith committed
    Added init_fun and stop_fun to poolboy's config proplist.
    These functions are used to init and stop workers as they're
    added and removed from a pool. These functions allow poolboy
    to pool processes which need additional processing before they
    are ready to be added or removed from the pool.
    
    The motivation for adding these functions is the case where poolboy
    is managing a pool of database connection processes. These processes
    need to load prepared statements immediately after they are created
    and before they are placed in the pool. Prior to adding these functions
    the only way to pool these processes was to wrap them in additional code
    to handle the post-connection initialization. These functions now
    permit poolboy to pool the database connections without wrapping them.
Commits on Sep 30, 2011
  1. Bump the version number (0.4)

    Devin Torres committed
  2. Try to address issue #2 with an optional timeout paramenter on checko…

    Devin Torres committed
    …ut (default: 5000)
    
    Some people value the let-it-fail philosophy which would allow the pool to fail when it can't send the event in time. Others may want to mimic a wholly blocking interface with infinity.
  3. Merge cleanup and try to cleanup the tests

    Devin Torres committed
Commits on Sep 29, 2011
  1. Oops, actually fix merge conflict

    Devin Torres committed
Something went wrong with that request. Please try again.