From 4ae4a80219ba6d9404e8fd4666c45f77f3da9dd9 Mon Sep 17 00:00:00 2001 From: Philip Mueller Date: Wed, 12 Dec 2012 12:38:39 +0100 Subject: [PATCH 1/3] change cover html generation to produce valid html - added missing doctype - added encoding statement - removed invalid additional opening tag --- src/rebar_eunit.erl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/rebar_eunit.erl b/src/rebar_eunit.erl index b82da0f5..c674ad93 100644 --- a/src/rebar_eunit.erl +++ b/src/rebar_eunit.erl @@ -524,7 +524,9 @@ align_notcovered_count(Module, Covered, NotCovered, true) -> cover_write_index(Coverage, SrcModules) -> {ok, F} = file:open(filename:join([?EUNIT_DIR, "index.html"]), [write]), - ok = file:write(F, "Coverage Summary\n"), + ok = file:write(F, "\n" ++ + "Coverage Summary\n" ++ + "\n"), IsSrcCoverage = fun({Mod,_C,_N}) -> lists:member(Mod, SrcModules) end, {SrcCoverage, TestCoverage} = lists:partition(IsSrcCoverage, Coverage), cover_write_index_section(F, "Source", SrcCoverage), @@ -542,7 +544,7 @@ cover_write_index_section(F, SectionName, Coverage) -> TotalCoverage = percentage(Covered, NotCovered), %% Write the report - ok = file:write(F, ?FMT("

~s Summary

\n", [SectionName])), + ok = file:write(F, ?FMT("

~s Summary

\n", [SectionName])), ok = file:write(F, ?FMT("

Total: ~s

\n", [TotalCoverage])), ok = file:write(F, "\n"), From e29d84fbf6916d506f1e640c9d81af4454bf3a11 Mon Sep 17 00:00:00 2001 From: Philip Mueller Date: Wed, 30 Jan 2013 14:24:54 +0100 Subject: [PATCH 2/3] break overlong line --- src/rebar_eunit.erl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/rebar_eunit.erl b/src/rebar_eunit.erl index c674ad93..55f10970 100644 --- a/src/rebar_eunit.erl +++ b/src/rebar_eunit.erl @@ -525,7 +525,8 @@ align_notcovered_count(Module, Covered, NotCovered, true) -> cover_write_index(Coverage, SrcModules) -> {ok, F} = file:open(filename:join([?EUNIT_DIR, "index.html"]), [write]), ok = file:write(F, "\n" ++ - "Coverage Summary\n" ++ + "" ++ + "Coverage Summary\n" ++ "\n"), IsSrcCoverage = fun({Mod,_C,_N}) -> lists:member(Mod, SrcModules) end, {SrcCoverage, TestCoverage} = lists:partition(IsSrcCoverage, Coverage), From c79314593d0ca1a20eee3cbca4deec70b54e5d53 Mon Sep 17 00:00:00 2001 From: Philip Mueller Date: Sun, 16 Jun 2013 16:15:14 +0200 Subject: [PATCH 3/3] remove superfluous string concat operator usage --- src/rebar_eunit.erl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/rebar_eunit.erl b/src/rebar_eunit.erl index 55f10970..a6a68ce3 100644 --- a/src/rebar_eunit.erl +++ b/src/rebar_eunit.erl @@ -524,9 +524,9 @@ align_notcovered_count(Module, Covered, NotCovered, true) -> cover_write_index(Coverage, SrcModules) -> {ok, F} = file:open(filename:join([?EUNIT_DIR, "index.html"]), [write]), - ok = file:write(F, "\n" ++ - "" ++ - "Coverage Summary\n" ++ + ok = file:write(F, "\n" + "" + "Coverage Summary\n" "\n"), IsSrcCoverage = fun({Mod,_C,_N}) -> lists:member(Mod, SrcModules) end, {SrcCoverage, TestCoverage} = lists:partition(IsSrcCoverage, Coverage),
ModuleCoverage %