Add root_dir option to reltool.config #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating a node using rebar generate, rebar always used code:root_dir() to find the Erlang installation to clone into the node tree. However, for anyone wishing to build a cross-compiled node, there was no way to override this. This patch adds a new option to reltool.config file to allow an alternate root_dir to be specified, for example:
{root_dir, "/tmp/otp_R14B03_armv7l"}
This assumes that the contents of /tmp/otp_R14B03_armv7l has been generated using the instructions found in the xcomp directory in your $ERL_TOP structure. NOTE: you may have to add additional filters to exclude files not present in the xcomp version, such as the .smp files if you have disabled that.
|
Thanks, merged and refactored reltool root_dir lookup. |
ghost
closed this
jaredmorrow
pushed a commit
that referenced
this pull request
Nov 5, 2013
CONTRIBUTING: apply stylistic change suggested by dizzyd
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a node using rebar generate, rebar always used code:root_dir() to find the Erlang installation to clone into the node tree. However, for anyone wishing to build a cross-compiled node, there was no way to override this. This patch adds a new option to reltool.config file to allow an alternate root_dir to be specified, for example:
{root_dir, "/tmp/otp_R14B03_armv7l"}This assumes that the contents of /tmp/otp_R14B03_armv7l has been generated using the instructions found in the xcomp directory in your $ERL_TOP structure. NOTE: you may have to add additional filters to exclude files not present in the xcomp version, such as the .smp files if you have disabled that.