Improvements to windows node runner script #194

Closed
wants to merge 2 commits into from

4 participants

@xenolinguist
  • Typos and other minor bug fixes
  • Add "attach" command (via -remsh)
  • Add "upgrade" command to install a hot upgrade package
@joewilliams

These seem like nice changes, can you also make them to the Unix runner script?

@xenolinguist

Can someone with more rebar+Unix experience please test the latest commit to make sure I got the bash-fu right?

Thanks!

@joewilliams joewilliams commented on an outdated diff Apr 2, 2012
priv/templates/simplenode.install_upgrade.escript
@@ -0,0 +1,39 @@
+#!/usr/bin/env escript
+%%! -noshell -noinput
+%% -*- mode: erlang;erlang-indent-level: 4;indent-tabs-mode: nil -*-
+%% ex: ft=erlang ts=4 sw=4 et
+
+-define(TIMEOUT, 60000).
+-define(INFO(Fmt,Args), io:format(Fmt,Args)).
+
+main([NodeName, Cookie, ReleasePackage]) ->
+ TargetNode = start_distribution(NodeName, Cookie),
+ {ok, Vsn} = rpc:call(TargetNode, release_handler, unpack_release, [ReleasePackage], ?TIMEOUT),

I would like to see release_handler:check_install_release/1 used here so we can exit out cleanly before we attempt the install. This is nice because depending on how the install fails during install_release the VM might be restarted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@joewilliams

Any update on these changes? I would like to get them merged in!

xenolinguist and others added some commits Jan 9, 2012
@xenolinguist xenolinguist Improvements to windows node runner script
* Typos and other minor bug fixes
* Add "attach" command (via -remsh)
* Add "upgrade" command to install a hot upgrade package
* Add "upgrade" subcommand to UNIX runner script as well
76983c5
@fjoanis fjoanis Use correctly escaped pipes in usage message 68b82af
@tuncer

Thanks, merged.

@tuncer tuncer closed this Apr 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment