Ping Type Spec #52

Closed
bfrog opened this Issue Apr 18, 2012 · 4 comments

Comments

Projects
None yet
2 participants
@bfrog

bfrog commented Apr 18, 2012

The type spec for riakc_pb_socket:ping/2 function has ok | {error, _} as the return type when in reality the response is pong | {error, _}.

It would be good to either fix the spec to match reality or fix the response to match the spec so dialyzer isn't complaining I've done things wrong when I have

pong = ...:ping(...)

@seancribbs

This comment has been minimized.

Show comment
Hide comment
@seancribbs

seancribbs Apr 18, 2012

Contributor

@bfrog Pull-request? Seems best to fix the -spec.

Contributor

seancribbs commented Apr 18, 2012

@bfrog Pull-request? Seems best to fix the -spec.

@bfrog

This comment has been minimized.

Show comment
Hide comment
@bfrog

bfrog Apr 18, 2012

I tried making a patch and pushing it to my fork on github, github seems to have mysteriously lost my branch.

bfrog commented Apr 18, 2012

I tried making a patch and pushing it to my fork on github, github seems to have mysteriously lost my branch.

@seancribbs

This comment has been minimized.

Show comment
Hide comment
@seancribbs

seancribbs Apr 18, 2012

Contributor

@bfrog Ouch. The diff in a gist (or other pastebin) would be sufficient, if you have it.

Contributor

seancribbs commented Apr 18, 2012

@bfrog Ouch. The diff in a gist (or other pastebin) would be sufficient, if you have it.

@seancribbs

This comment has been minimized.

Show comment
Hide comment
@seancribbs

seancribbs Jan 31, 2013

Contributor

This was addressed in #81, thanks @cdahlqvist.

Contributor

seancribbs commented Jan 31, 2013

This was addressed in #81, thanks @cdahlqvist.

@seancribbs seancribbs closed this Jan 31, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment