Skip to content

Loading…

Ping Type Spec #52

Closed
bfrog opened this Issue · 4 comments

2 participants

@bfrog

The type spec for riakc_pb_socket:ping/2 function has ok | {error, _} as the return type when in reality the response is pong | {error, _}.

It would be good to either fix the spec to match reality or fix the response to match the spec so dialyzer isn't complaining I've done things wrong when I have

pong = ...:ping(...)

@seancribbs

@bfrog Pull-request? Seems best to fix the -spec.

@bfrog

I tried making a patch and pushing it to my fork on github, github seems to have mysteriously lost my branch.

@seancribbs

@bfrog Ouch. The diff in a gist (or other pastebin) would be sufficient, if you have it.

@seancribbs

This was addressed in #81, thanks @cdahlqvist.

@seancribbs seancribbs closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.