Fix issue with reloading deleted objects over PBC. #238

Merged
merged 1 commit into from Apr 19, 2013

Conversation

Projects
None yet
3 participants
  • Reinstated @shuhaowu's obj.reload() in bucket delete test.
  • Set obj.exists to False if there are no contents, resolving reload
    problem.
Fix issue with reloading deleted objects over PBC.
* Reinstated @shuhaowu's obj.reload() in bucket delete test.
* Set obj.exists to False if there are no contents, resolving reload
  problem.

@ghost ghost assigned seancribbs Apr 5, 2013

Contributor

shuhaowu commented on ee54fd4 Apr 5, 2013

Is this just a work around? I'm not sure what the status returned by PBC is in the case where contents = []

Perhaps we should use clear. That's extra work, however. The alternative is we could declare that if an object retrieved has .exists to be False, the object is invalid.

When contents are empty, the significance is "not found".

Your point is well taken, however. This is just a band-aid for more rigorous handling of siblings, which I am working on in another branch.

Fix checks out. 👍 to merge!

@ghost ghost assigned javajolt Apr 19, 2013

seancribbs added a commit that referenced this pull request Apr 19, 2013

Merge pull request #238 from basho/sdc-fix-pbc-deleted
Fix issue with reloading deleted objects over PBC.

@seancribbs seancribbs merged commit f6c6e9b into master Apr 19, 2013

1 check failed

default The Travis build failed
Details

@seancribbs seancribbs deleted the sdc-fix-pbc-deleted branch Apr 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment