Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Unable to build Riak from source tarball while offline #345

Closed
jaredmorrow opened this Issue Jun 28, 2013 · 0 comments

Comments

Projects
None yet
1 participant
Contributor

jaredmorrow commented Jun 28, 2013

The riak source tarball provided as a download each release does not contain the entirety of the riak code base. The leveldb source code is not included.

This causes issues that have been reported many times by users and documented on our docs page under the section "Installation on Closed Networks".

This issue gives our users a bad experience and should be fixed.

@ghost ghost assigned jaredmorrow Jun 28, 2013

jaredmorrow pushed a commit that referenced this issue Jun 28, 2013

Include leveldb source code in riak source distribution
When building riak's source tarball, `git archive` is used
to ensure clean repositories are used rather than working
directories that might have uncommited changes.  This works
fine except for one special case where eleveldb downloads
leveldb into its source tree.  In this case 'git archive'
then removes the leveldb source because it is not truly
a committed file in eleveldb's repository.

The side effect of this issue are users who try to build
riak from source while either offline or without access
to github while building.  Any build will fail because
eleveldb does not have leveldb's source tree that is needed.

This commit fixes that by using a work around to `git archive`
in the one special case of eleveldb.  The `.git` directories
are still cleaned, but the leveldb source tree is left intact.

The one downside to this change is eleveldb is not treated
differently than every other repository and local changes
to eleveldb's source tree can possibly leak into the source
tarball.  This however is very unlikely due to `make dist`
using a completely separate `make deps` chain than the standard
developer `make deps`.  Basically someone would have to really
try hard to mess it up.

This addresses basho/riak#345

jaredmorrow pushed a commit to basho/basho_docs that referenced this issue Jun 28, 2013

Remove note about closed networks
The source tarball bug that required the closed networks
section has been fixed in basho/riak#345 so this section
is no longer needed in 1.4.0 and above.

@jaredmorrow jaredmorrow referenced this issue in basho/basho_docs Jun 28, 2013

Merged

Remove note about closed networks #460

hmmr pushed a commit that referenced this issue Nov 8, 2016

Merge pull request #345 from basho/feature/releasenote-2.0.6-ja
Translated releasenote 2.0.6 into Japanese
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment