Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Riak should manage backend lock files. #535

Open
evanmcc opened this Issue · 0 comments

1 participant

Evan Vigil-McClanahan
Evan Vigil-McClanahan

There have been a couple of issues on bitcask and I think at least one on leveldb where stale lock files keep the system or particular vnodes from starting up. There've been repeated requests (basho/bitcask#99, basho/bitcask#163) to manage this at the backend level, but IMO, that's the wrong place to handle it, since there are various corner cases that the backend really shouldn't be responsible for detecting. I lay out some of my thinking here:
basho/bitcask#99 (comment)

The ideal thing in my mind is to have riak at the top/service level guarantee uniqueness, and then to extend the backend API to have a cleanup_locks call when riak/some other containing application has determined that it's totally safe to do so.

This was kind of a distant corner case before, but as containerization gets more common, we're seeing this more and more, and that trend looks only to increase, so best to deal with it soon.

cc @bsparrow435 @joecaswell

Evan Vigil-McClanahan evanmcc added this to the 2.1 milestone
Evan Vigil-McClanahan evanmcc added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.