Skip to content

Added `riak-admin cluster members` #231

Closed
wants to merge 1 commit into from

5 participants

@lenary
lenary commented Oct 16, 2012

This lets users see current cluster membership. It does exactly the
same as riak-admin member-status only it's in the cluster subcommand,
where I feel it should live.

I kept tripping up on the fact that the cluster membership commands weren't in the same place as the cluster altering commands, so I decided to make it so! Open Source ftw!

The old commands still work, and perhaps there's a better way of keeping backwards compatibility than duplicating code. I guess one can just call the other.

@lenary lenary Added `riak-admin cluster members`
This lets users see current cluster membership. It does exactly the
same as `riak-admin member-status` only it's in the cluster subcommand,
where I feel it should live.
29cba8f
@jaredmorrow

I like the idea, but might not get a chance to look at it in detail for a little bit. Sorry to push it off, just want to make sure you know someone saw this! Thanks for the PR!

@evanmcc

I suspect that this should actually be a riak_core_console change, if we're going to do it.

How do you mean?

This changed the behavior of the controller script without changing anything in riak_core. If the riak_core behavior is inconsistent, we should make changes both places, rather than just in the script.

All I did was copy the riak-admin member_status to riak-admin cluster members - I don't think there's inconsistent behaviour in riak_core itself. The script just more closely matches what's in my head for managing the cluster.

@jaredmorrow

Since @jtuple did the work on the new cluster subcommand I'll let him decide if he wants this functionality moved.

@slfritchie

Ping ... is this PR needed for Riak 2.0?

@jrwest
jrwest commented Dec 24, 2013

It is not needed. At a minimum it needs to be re-opened to point at develop instead of master and I imagine requires a merge/rebase given the changes to riak-admin this time around. Closing for now with the expectation that @lenary will re-open if he wants.

@jrwest jrwest closed this Dec 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.