Integrate the Exometer metrics package #448

Closed
wants to merge 18 commits into
from

Conversation

Projects
None yet
5 participants
@uwiger
Contributor

uwiger commented Dec 5, 2013

Exometer is a metrics application developed for Basho by Feuerlabs. Among other things, it offers:

  • More dynamic management of metrics (including enabling/disabling metrics at runtime)
  • More cost-effective histograms
  • Custom metrics
  • Reporters to external services such as Graphite and Collectd

This pull request depends on a number of other PRs, i.e. basho/riak_core#465, basho/riak_kv#748, basho/riak_api#45, basho/riak_pipe#81, basho/riak_control#175, basho/riak_search#155, basho/yokozuna#246, basho/sidejob#4

According to our benchmarks, this PR slightly improves throughput and latency:

summary-exo

compared to the starting point (the develop branch as of Dec 3):

summary-orig

Since it is possible to selectively and dynamically disable metrics, throughput can be further increased at the expense of metrics information.

Memory footprint has also been reduced, likely due to less caching and more economical histograms:

memory-usage-exo

compared to the starting point:

memory-usage-orig

rel/reltool.config
{template, "../deps/riak_kv/priv/multi_backend.schema", "lib/20-multi_backend.schema"},
{template, "../deps/eleveldb/priv/eleveldb.schema", "lib/21-leveldb.schema"},
+ {template, "../deps/sidejob/priv/sidejob.schema", "lib/22-sidejob.schema"},

This comment has been minimized.

Show comment Hide comment
@evanmcc

evanmcc Dec 6, 2013

Contributor

this line needs to be removed if we're removing exometer/sidejob stuff.

@evanmcc

evanmcc Dec 6, 2013

Contributor

this line needs to be removed if we're removing exometer/sidejob stuff.

This comment has been minimized.

Show comment Hide comment
@uwiger

uwiger Dec 6, 2013

Contributor

Apologies. I had done that, but not pushed it. Pushed now.

2013/12/6 Evan Vigil-McClanahan notifications@github.com

In rel/reltool.config:

        {template, "../deps/riak_kv/priv/multi_backend.schema", "lib/20-multi_backend.schema"},
        {template, "../deps/eleveldb/priv/eleveldb.schema", "lib/21-leveldb.schema"},
  •       {template, "../deps/sidejob/priv/sidejob.schema", "lib/22-sidejob.schema"},
    

this line needs to be removed if we're removing exometer/sidejob stuff.


Reply to this email directly or view it on GitHubhttps://github.com/basho/riak/pull/448/files#r8168872
.

@uwiger

uwiger Dec 6, 2013

Contributor

Apologies. I had done that, but not pushed it. Pushed now.

2013/12/6 Evan Vigil-McClanahan notifications@github.com

In rel/reltool.config:

        {template, "../deps/riak_kv/priv/multi_backend.schema", "lib/20-multi_backend.schema"},
        {template, "../deps/eleveldb/priv/eleveldb.schema", "lib/21-leveldb.schema"},
  •       {template, "../deps/sidejob/priv/sidejob.schema", "lib/22-sidejob.schema"},
    

this line needs to be removed if we're removing exometer/sidejob stuff.


Reply to this email directly or view it on GitHubhttps://github.com/basho/riak/pull/448/files#r8168872
.

@thefosk

This comment has been minimized.

Show comment Hide comment
@thefosk

thefosk Mar 24, 2014

+1

thefosk commented Mar 24, 2014

+1

@uwiger uwiger referenced this pull request Jul 29, 2014

Closed

use exometer metrics #576

@jburwell

This comment has been minimized.

Show comment Hide comment
@jburwell

jburwell Nov 19, 2014

Contributor

Superseded by #621

Contributor

jburwell commented Nov 19, 2014

Superseded by #621

@jburwell jburwell closed this Nov 19, 2014

@jburwell jburwell deleted the feuerlabs-exometer branch Nov 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment