Enable multiple PB listeners. #23

Merged
merged 1 commit into from Mar 16, 2013

Projects

None yet

2 participants

@seancribbs

Works similarly to the http/https settings in riak_core. The previous settings, pb_ip and pb_port are now deprecated, and the legacy riak_kv settings are now removed/ignored.

@seancribbs seancribbs was assigned Feb 26, 2013
@russelldb russelldb was assigned Mar 14, 2013
@russelldb
Member

I get "Warning in app.config: pb_port undefined, protobuffs interface not enabled" when I use the following config:

{pb, [{"127.0.0.1", 8087}, {"10.0.0.12", 8073}]}

Apart from that, looks good, confirm it works, tests pass. Another PR for this fix (https://github.com/basho/riak/tree/riak_api23-pb-listeners) to nodetool?

@seancribbs

@russelldb Weird, I had no idea that even existed in nodetool. Thanks for finding it.

@seancribbs seancribbs referenced this pull request in basho/riak Mar 15, 2013
Merged

Support multiple PB listeners #290

@seancribbs seancribbs was assigned Mar 16, 2013
@seancribbs seancribbs merged commit f506a12 into master Mar 16, 2013

1 check passed

Details default The Travis build passed
@seancribbs seancribbs deleted the sdc-multiple-listeners branch Mar 16, 2013
@metadave metadave pushed a commit to metadave/riak that referenced this pull request Dec 9, 2013
@russelldb russelldb Update the `pb` config check inline with latest riak_api code 23b4a87
@seancribbs seancribbs removed their assignment May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment