Add swap/3 API #31

Merged
merged 1 commit into from Aug 22, 2013

Conversation

Projects
None yet
2 participants
@rzezeski
Contributor

rzezeski commented Aug 22, 2013

Add ability to atomically swap the callback module for a given code
range. The exact code range must already be registered or an error
tuple is returned.

NOTE: This is needed for migrating from Riak Search to Yokozuna, see basho/yokozuna#20.

@seancribbs

This comment has been minimized.

Show comment
Hide comment

Tests?

Add swap/3 API
Add ability to atomically swap the callback module for a given code
range.  The exact code range must already be registered or an error
tuple is returned.
@rzezeski

This comment has been minimized.

Show comment
Hide comment
@rzezeski

rzezeski Aug 22, 2013

Contributor

Forced pushed fix + test.

Contributor

rzezeski commented Aug 22, 2013

Forced pushed fix + test.

@seancribbs

This comment has been minimized.

Show comment
Hide comment
@seancribbs

seancribbs Aug 22, 2013

👍 I could bikeshed about testing the registration swap independent of running server processes, but your test covers both the swap and the result of swapping.

👍 I could bikeshed about testing the registration swap independent of running server processes, but your test covers both the swap and the result of swapping.

@rzezeski

This comment has been minimized.

Show comment
Hide comment
@rzezeski

rzezeski Aug 22, 2013

Contributor

How do bike sheds even get painted.

Thanks for review.

Contributor

rzezeski commented Aug 22, 2013

How do bike sheds even get painted.

Thanks for review.

rzezeski added a commit that referenced this pull request Aug 22, 2013

@rzezeski rzezeski merged commit ce34d49 into master Aug 22, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details

@rzezeski rzezeski referenced this pull request in basho/yokozuna Aug 22, 2013

Closed

Riak Search Migration [JIRA: RIAK-1713] #20

7 of 10 tasks complete

@seancribbs seancribbs deleted the feature/rz/swap branch Aug 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment