Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add riak_core as application dep to riak_api.app #6

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
3 participants
Member

russelldb commented Jul 16, 2012

When generating a release with erlang r14b0* riak fails to start with:

{"Kernel pid terminated",application_controller,
    "{application_start_failure,riak_api,{bad_return, {{riak_api_app,start,[normal,[]]},
        {'EXIT',{noproc,{gen_server,call,
           [riak_core_stat_cache,{register,riak_api,{riak_api_stat,produce_stats,[]},5}]}}}}}}"}

This is due to the start order in the generated riak.script.
According to systools' man page -

"The applications are sorted according to the dependencies between
the applications. Where there are no dependencies, the order in the
.rel file is kept."

There may be a better way to control the
order in the rel file, but this PR fixes the issue by
declaring riak_api's dependency on riak_core.

Add riak_core as application dep to riak_api.app
When generating a release with erlang r14b0* riak fails to start.
This is due to the start order in the generated riak.script.
According to systools man page -
"The applications are sorted according to the dependencies between
the applications. Where there are no dependencies, the order in the
.rel file is kept." There may be a better way to control the
order in the rel file, but this PR fixes the issue by
declaring riak_api's dependency on riak_core.

@ghost ghost assigned seancribbs Jul 16, 2012

@russelldb russelldb commented on the diff Jul 17, 2012

rebar.config
@@ -1,5 +1,6 @@
{cover_enabled, true}.
{erl_opts, [warnings_as_errors, {parse_transform, lager_transform}]}.
+{eunit_opts, [verbose]}.
@russelldb

russelldb Jul 17, 2012

Member

Do we want to keep this in?

@seancribbs

seancribbs Jul 17, 2012

Yes. It helps us see which test failed when we get an intermittent error, whereas the default mode isn't helpful at all.

@seancribbs seancribbs referenced this pull request in basho/riak Jul 17, 2012

Closed

riak 1.2 is not starting on mac os x lion #185

This was merged into the 1.2 branch.

@seancribbs seancribbs closed this Jul 19, 2012

@ghost ghost assigned jonmeredith Jul 20, 2012

@zhangwz zhangwz referenced this pull request in basho/riak Dec 29, 2012

Closed

riak start failure after several seconds #263

@seancribbs seancribbs deleted the rdb-r14-rel-boot-script branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment