Integrate the Exometer metrics package #175

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants

uwiger commented Dec 5, 2013

This PR is part of a set of PRs aimed at integrating the Exometer metrics package into Riak.

(From basho/riak_core#465)

From our measurements so far, Exometer offers both better throughput and lower footprint than the previous metrics management, and at the same time offers more flexible and uniform handling and better extensibility.

In addition to maintaining the console command riak-admin status and the HTTP JSON report (which aim to be backwards-compatible), a new console command, riak-admin stat <cmd> has been added, for selective reporting of statistics as well as some management (ability to enable/disable metrics on the fly).

Other noteworthy changes:

  • Exometer entry names are always lists. In riak, only atoms and numbers should be used as list elements.
  • A top-level 'prefix' (default: riak) has been added, in order to differentiate between stats from different riak-style products (e.g. when reporting stats to collectd). The function riak_core_stat:prefix() is generated as a constant expression through the parse transform riak_core_stat_xform, which in its turn checks the OS env variable RIAK_CORE_STAT_PREFIX. A typical entry would thus be e.g. [riak,riak_kv,node,gets,siblings].
  • Internally in riak, stats are referred to symbolically using the same (tuple-based) names as before. These often refer to more than one low-level metric, so it seemed reasonable to keep this naming scheme.
  • Exometer provides similar functionality as 'sidejob' and the riak_core stat cache, so these are no longer used for stats management (although sidejob still maintains some stats on its own, which are accessible via Exometer). Other apps still register with riak_core_stat, but need not provide callbacks in other to query the stats. The query style of exometer is the same as that of riak_core_stat.

@uwiger uwiger referenced this pull request in basho/riak Dec 5, 2013

Closed

Integrate the Exometer metrics package #448

uwiger commented Dec 5, 2013

The Travis CI build failed due to a rebar.config issue in the riak_core feuerlabs-exometer branch (wrong git protocol). This has been fixed.

Contributor

cmeiklejohn commented Mar 24, 2014

Moving to 2.1 with the rest of the exometer work.

@cmeiklejohn cmeiklejohn added this to the 2.1 milestone Mar 24, 2014

@uwiger uwiger referenced this pull request Jul 29, 2014

Closed

use exometer metrics #182

jburwell commented Aug 1, 2014

This PR has been superseded by PR 182.

@jburwell jburwell closed this Aug 1, 2014

@seancribbs seancribbs deleted the feuerlabs-exometer branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment