Skip to content

Commit

Permalink
reintroduce previously exported riak_core_coverage_plan:create_plan/5
Browse files Browse the repository at this point in the history
jdaily has changed the arity of create_plan from 5 to 6 in a8fac28.

As this is an exported API function, its callers will be affected, hence
this fix.
  • Loading branch information
hmmr committed Jan 8, 2016
1 parent 39e6e33 commit 3fe6c86
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion src/riak_core_coverage_plan.erl
Expand Up @@ -94,7 +94,7 @@
-endif.

%% API
-export([create_plan/6, create_subpartition_plan/6]).
-export([create_plan/5, create_plan/6, create_subpartition_plan/6]).
-export([replace_subpartition_chunk/7, replace_traditional_chunk/7]).

%% For other riak_core applications' coverage plan modules
Expand Down Expand Up @@ -148,6 +148,17 @@

%% @doc Create Riak's traditional coverage plan to distribute work to
%% a minimal set of covering VNodes around the ring.
-spec create_plan(vnode_selector(),
pos_integer(),
pos_integer(),
req_id(), atom()) ->
{error, term()} | coverage_plan().
create_plan(VNodeTarget, NVal, PVC, ReqId, Service) ->
%% jdaily added a sixth parameter, _Request, which is ignored
%% here, apparently used in coverage API work. See
%% riak_kv_qry_coverage_plan:create_plan for more clues.
create_plan(VNodeTarget, NVal, PVC, ReqId, Service, undefined).

-spec create_plan(vnode_selector(),
pos_integer(),
pos_integer(),
Expand Down

5 comments on commit 3fe6c86

@borshop
Copy link
Contributor

@borshop borshop commented on 3fe6c86 Jan 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from javajolt
at 3fe6c86

@borshop
Copy link
Contributor

@borshop borshop commented on 3fe6c86 Jan 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging basho/riak_core/fix/az/reintroduce-create_plan/5 = 3fe6c86 into borshop-integration-802-fix/az/reintroduce-create_plan/5

@borshop
Copy link
Contributor

@borshop borshop commented on 3fe6c86 Jan 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basho/riak_core/fix/az/reintroduce-create_plan/5 = 3fe6c86 merged ok, testing candidate = cc8f547

@borshop
Copy link
Contributor

@borshop borshop commented on 3fe6c86 Jan 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borshop
Copy link
Contributor

@borshop borshop commented on 3fe6c86 Jan 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding end-to-end/timeseries to borshop-integration-802-fix/az/reintroduce-create_plan/5 = cc8f547

Please sign in to comment.