Skip to content

riak-admin wait-for-service riak_kv <bad_node_name> does not return error #151

Open
bsparrow435 opened this Issue Mar 14, 2012 · 5 comments

4 participants

@bsparrow435
Basho Technologies member

Running riak-admin wait-for-service riak_kv with a bad node name (i.e. localhost) return:

riak_kv is not up: []

No indication that this is a bad node name. Suggest putting logic in to check node name for cluster membership or ability to ping.

Identified in 1045 during upgrade from 0.14 to 1.1.1 (https://help.basho.com/tickets/1045)

@jrwest
jrwest commented Aug 9, 2013

verified this still occurs on master today. I've actually been bit by this working on some automated perf testing. this should be fixed in the next release or two so it will be left open.

@slfritchie

@jrwest @bsparrow435 @deanproctor Hrm, since Dean's recent PR #385 was recently withdrawn without merging, what's the New Plan?

@jrwest
jrwest commented Sep 27, 2013

@slfritchie @deanproctor opened basho/riak#394 to handle the case where no node name is provided. I agree w/ @evanmcc that handling the invalid node-name should probably be handled here in core. I don't think we have plans for 2.0 (although maybe we will get to it right now its on the "Next Release + 1" milestone)

@evanmcc
@jrwest
jrwest commented Mar 24, 2014

not happening for 2.0-* but moving to 2.0.1 since I still think this is a good/quick/easy/etc fix.

@jrwest jrwest modified the milestone: 2.0.1, Next Release + 1 Mar 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.