Don't read ring files from the future #162

Closed
Vagabond opened this Issue Apr 4, 2012 · 6 comments

Comments

Projects
None yet
5 participants
Contributor

Vagabond commented Apr 4, 2012

If a ringfile is written with a sufficiently skewed timestamp, subsequent ring updates will be ignored on node restart until the ring file timestamp is no longer is in the future. This can cause very surprising behaviour,

A simple way to replicate is simply to change the 'year' part of the ringfile's timestamp to a year in the future, change some ring configs, and restart the node.

Better behaviour would at least be to warn about a ring file from the future, or refuse to load it at all.

@rzezeski rzezeski added a commit that referenced this issue Apr 21, 2013

@rzezeski rzezeski Merge pull request #162 from basho/az609-extractor-bucket-props
Teach riak_kv to understand search extractor prop
134a422
Contributor

jrwest commented Aug 9, 2013

marked as bug and that there are intentions to fix in near future.

Contributor

slfritchie commented Sep 27, 2013

@Vagabond @jrwest Time for some belated repo curating ... is there any plan to fix this for Riak 2.0? ... It seems to me that @rzezeski's reference to this issue number was a typo? Because I don't see anything in that commit that deals with ring files.

Contributor

Vagabond commented Sep 27, 2013

I've no intent to fix it in 2.0.

Contributor

rzezeski commented Sep 27, 2013

@slfritchie This is from GitHub automatically linking because of the #162 in the commit message. I have no involvement in this ticket. Well...I guess that isn't true anymore :)

Contributor

jrwest commented Sep 27, 2013

@slfritchie no intent for 2.0 that I know of. its marked "Next Release + 1" right now.

Contributor

jrwest commented Mar 24, 2014

moved to 2.1 milestone

@jrwest jrwest modified the milestone: 2.1, Next Release + 1 Mar 24, 2014

bsparrow435 closed this Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment