Dependencies cleanup? #272

Closed
yrashk opened this Issue Feb 16, 2013 · 17 comments

Comments

Projects
None yet
8 participants
@yrashk

yrashk commented Feb 16, 2013

Hi,

Some of us riak_core users have been discussing the list of dependencies riak_core has, and to our best understanding some of them don't exactly belong to riak_core itself (webmachine, mochiweb, protobuffs, etc.).

Do you guys think there is a chance we can do some cleanup in that area?

Thanks

@tsloughter

This comment has been minimized.

Show comment Hide comment
@tsloughter

tsloughter Feb 16, 2013

+1, I've started with it on a fork https://github.com/tsloughter/riak_core

+1, I've started with it on a fork https://github.com/tsloughter/riak_core

@omarkj

This comment has been minimized.

Show comment Hide comment
@omarkj

omarkj Feb 17, 2013

+1

omarkj commented Feb 17, 2013

+1

@seancribbs

This comment has been minimized.

Show comment Hide comment
@seancribbs

seancribbs Feb 17, 2013

Contributor
  1. protobuffs is needed for handoff. I don't know what our engineers are planning for the next revision, but this may change.
  2. webmachine and friends will likely move to riak_api when we have a better idea of how to reorganize the startup and shutdown sequence. Ideas are welcome in this area.
Contributor

seancribbs commented Feb 17, 2013

  1. protobuffs is needed for handoff. I don't know what our engineers are planning for the next revision, but this may change.
  2. webmachine and friends will likely move to riak_api when we have a better idea of how to reorganize the startup and shutdown sequence. Ideas are welcome in this area.
@evanmcc

This comment has been minimized.

Show comment Hide comment
@evanmcc

evanmcc Feb 17, 2013

Contributor

cc @chardan re handoff

Contributor

evanmcc commented Feb 17, 2013

cc @chardan re handoff

@yrashk

This comment has been minimized.

Show comment Hide comment
@yrashk

yrashk Feb 17, 2013

@seancribbs seems to be a tricky part with protobuffs — can't find any direct reference to it besides the riak_core.proto file

yrashk commented Feb 17, 2013

@seancribbs seems to be a tricky part with protobuffs — can't find any direct reference to it besides the riak_core.proto file

@russelldb

This comment has been minimized.

Show comment Hide comment
@russelldb

russelldb Feb 17, 2013

Member

What is the aim, and what are your criteria for 'belongs'? Folsom provides stats, riak_core provides stats. I see in @tsloughter's fork riak_core does not have stats any longer. Is that OK? And what is the cost of the deps you want to cut, what do you gain from cutting them?

Member

russelldb commented Feb 17, 2013

What is the aim, and what are your criteria for 'belongs'? Folsom provides stats, riak_core provides stats. I see in @tsloughter's fork riak_core does not have stats any longer. Is that OK? And what is the cost of the deps you want to cut, what do you gain from cutting them?

@seancribbs

This comment has been minimized.

Show comment Hide comment
@seancribbs

seancribbs Feb 17, 2013

Contributor

@yrashk I guarantee you handoff will not work without it. Look for references to riak_core_pb

Contributor

seancribbs commented Feb 17, 2013

@yrashk I guarantee you handoff will not work without it. Look for references to riak_core_pb

@yrashk

This comment has been minimized.

Show comment Hide comment
@yrashk

yrashk Feb 17, 2013

@seancribbs I am just saying that it's a tricky "hard to spot" dependency :)

yrashk commented Feb 17, 2013

@seancribbs I am just saying that it's a tricky "hard to spot" dependency :)

@tsloughter

This comment has been minimized.

Show comment Hide comment
@tsloughter

tsloughter Feb 17, 2013

Yea, discovered the protobuff issue for handoffs today :).

So that definitely has to be added back unless it was made possible to handoff with a binary or something.

As for folsom, I was undecided on that. I use it myself for stats, so would end up with it in a riak_core project anyway, but if core is to just provide the building blocks for a distributed system someone may want to use another stat counter.

My gutting was more of an experiment, but I think necessary in some places.

Yea, discovered the protobuff issue for handoffs today :).

So that definitely has to be added back unless it was made possible to handoff with a binary or something.

As for folsom, I was undecided on that. I use it myself for stats, so would end up with it in a riak_core project anyway, but if core is to just provide the building blocks for a distributed system someone may want to use another stat counter.

My gutting was more of an experiment, but I think necessary in some places.

@tsloughter

This comment has been minimized.

Show comment Hide comment
@tsloughter

tsloughter Feb 17, 2013

@seancribbs I'm trying to find where the protobuff encoding is actually done for a handoff. Could you point me to it? I'm curious why protobuffs are used instead of simply Erlang binary terms.

@seancribbs I'm trying to find where the protobuff encoding is actually done for a handoff. Could you point me to it? I'm curious why protobuffs are used instead of simply Erlang binary terms.

@yrashk

This comment has been minimized.

Show comment Hide comment
@yrashk

yrashk Feb 17, 2013

...or a simple binary with three sized-encoded binaries?

yrashk commented Feb 17, 2013

...or a simple binary with three sized-encoded binaries?

@seancribbs

This comment has been minimized.

Show comment Hide comment
@seancribbs

seancribbs Feb 18, 2013

Contributor

Sorry, maybe the protobuffs are something that didn't get untangled when riak_core was extracted. Honestly, it's been over 2 years, and I wasn't involved at the time, so I don't know.

Contributor

seancribbs commented Feb 18, 2013

Sorry, maybe the protobuffs are something that didn't get untangled when riak_core was extracted. Honestly, it's been over 2 years, and I wasn't involved at the time, so I don't know.

@yrashk

This comment has been minimized.

Show comment Hide comment
@yrashk

yrashk Mar 2, 2013

speaking about webmachine, now that parametrized modules are gone, one can't (seemingly) build riak_core on R16 because basho's mochiweb hasn't been updated

yrashk commented Mar 2, 2013

speaking about webmachine, now that parametrized modules are gone, one can't (seemingly) build riak_core on R16 because basho's mochiweb hasn't been updated

@evanmcc

This comment has been minimized.

Show comment Hide comment
@evanmcc

evanmcc Mar 3, 2013

Contributor

On a new checkout? I thought out had gone into master.

Contributor

evanmcc commented Mar 3, 2013

On a new checkout? I thought out had gone into master.

@evanmcc

This comment has been minimized.

Show comment Hide comment
@evanmcc

evanmcc Aug 9, 2013

Contributor

#355 partially fixes this. I think that mochiweb is also or already removed, and protobuffs will be removed eventually.

Contributor

evanmcc commented Aug 9, 2013

#355 partially fixes this. I think that mochiweb is also or already removed, and protobuffs will be removed eventually.

@slfritchie

This comment has been minimized.

Show comment Hide comment
@slfritchie

slfritchie Sep 27, 2013

Contributor

Time for some belated repo curating ... is it worth keeping this issue open?

Contributor

slfritchie commented Sep 27, 2013

Time for some belated repo curating ... is it worth keeping this issue open?

@jrwest

This comment has been minimized.

Show comment Hide comment
@jrwest

jrwest Mar 24, 2014

Contributor

the dependencies mentioned are removed I believe. I'm going to close this issue out. If there is future discussion to be had, please feel free to re-open or leave a comment.

Contributor

jrwest commented Mar 24, 2014

the dependencies mentioned are removed I believe. I'm going to close this issue out. If there is future discussion to be had, please feel free to re-open or leave a comment.

@jrwest jrwest closed this Mar 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment