Review use of 'catch' and erlang:get_stacktrace() Riak-wide #477

Open
slfritchie opened this Issue Dec 11, 2013 · 4 comments

Comments

Projects
None yet
3 participants
Contributor

slfritchie commented Dec 11, 2013

Or, for an alternate title, "catch" without "try" considered harmful. See http://erlang.org/pipermail/erlang-questions/2013-November/075928.html and subsequent discussion for details.

Contributor

evanmcc commented Dec 11, 2013

If I am reading this correctly, the issue is that they are using exceptions
for flow control. Do we do that anywhere?

Contributor

slfritchie commented Dec 12, 2013

I know that past code that I myself have written uses 1-liner 'catch' statements. Any such that I or others have planted should probably be removed.

Contributor

evanmcc commented Dec 12, 2013

Done with the intention of usually hitting the exception, on hot paths?

@jrwest jrwest modified the milestones: 2.0.1, 2.1 Mar 24, 2014

Contributor

jrwest commented Mar 24, 2014

marked for 2.1 for now since this is "future un-categorized work". I'd actually love to see it done for 2.0.1, however, Happy to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment