Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Remove extra erl_opts #229

Merged
merged 1 commit into from

3 participants

@DeadZen

Remove duplicate erl_opts, keep debug_info

@seancribbs

Should probably add fail_on_warning in there to replace warnings_as_errors.

@DeadZen

I thought that, but decided since riak_core is meant to be included in other distributed applications; it might be dev overkill.

@seancribbs

@DeadZen Oh, I just meant that the option name has changed, was deprecated in R14. Unless I don't remember correctly?

@DeadZen

Gotcha, either way, I think it is best to leave it out of this rebar.config, for a few reasons:
It may prematurely impede development with riak_core and it can always be added to the embedding application.
Additionally the extra erl_opts, prevented it along with debug_info from being applied previously anyway.
I believe removing the additional erl_opts and keeping just the debug_info, is the path of least astonishment.

@rzezeski

@seancribbs It's still warning_as_errors. I'm going to accept the patch as-is. It can always be added against later if need be.

@DeadZen Looks good to me. I'm merging.

@rzezeski rzezeski merged commit 2994227 into basho:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 18, 2012
  1. @DeadZen

    Remove extra erl_opts

    DeadZen authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 2 deletions.
  1. +1 −2  rebar.config
View
3  rebar.config
@@ -1,8 +1,7 @@
{erl_first_files, ["src/gen_nb_server.erl", "src/riak_core_gen_server.erl"]}.
{cover_enabled, true}.
-{erl_opts, [{parse_transform, lager_transform}]}.
+{erl_opts, [{parse_transform, lager_transform}, debug_info]}.
{edoc_opts, [{preprocess, true}]}.
-{erl_opts, [debug_info, warnings_as_errors]}.
{deps, [
{lager, ".*", {git, "git://github.com/basho/lager", {branch, "master"}}},
Something went wrong with that request. Please try again.