Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't double-format sysmon messages, unexport unused functions #237

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

Vagabond commented Oct 4, 2012

This should more safely bound the memory used when printing lots of sysmon messages, as all the formatting is done via lager's trunc_io.

Contributor

kellymclaughlin commented Dec 5, 2012

Pushed rebased version of this branch here.

Contributor

kellymclaughlin commented Dec 5, 2012

+1 to merge. The rebased branch should merge cleanly, but careful if you merge this one there will be some conflicts.

Contributor

Vagabond commented Dec 5, 2012

Where do we need to merge this to for 1.3?

Contributor

kellymclaughlin commented Dec 5, 2012

It only needs to be on master I think, but I don't see any harm in merging it to 1.2 as well.

Contributor

Vagabond commented Dec 5, 2012

@jaredmorrow Suggestions?

Contributor

jaredmorrow commented Dec 5, 2012

If it is dataloss I'd put to 1.2 also, otherwise just master.

Contributor

Vagabond commented Dec 6, 2012

Merged by hand to master.

@Vagabond Vagabond closed this Dec 6, 2012

@seancribbs seancribbs deleted the adt-sysmon-format branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment