Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Logical Deletion of Ring Meta & Bucket Properties #248

merged 4 commits into from Nov 13, 2012


None yet
4 participants

jrwest commented Nov 1, 2012

Ability to reset bucket properties to default and remove other ring metadata as described in #197 and originally implemented in #202. The difference between this implementation and the original is deletion is logical (a tombstone value is written) instead of physical. Tombstones are never reaped currently but it is possible to do so in the future.

Corresponding riak_test for this functionality can be found here: basho/riak_test#81

jrwest added some commits Nov 1, 2012

@jrwest jrwest logical deletion of ring metadata
* re-implementation of #202 using the tombstone method described here: #202 (comment) -- the implementation is a bit more general in that it applies to all metadata in the dict not just bucket props (riak_core_ring:get_meta/3 is tombstone aware rather than riak_core_bucket:get_bucket/1)
* tombstones are not currently reaped although it possible to do so in the future
@jrwest jrwest function for resting bucket to default properties 945019b

@jrwest jrwest was assigned Nov 1, 2012

@jrwest jrwest referenced this pull request in basho/riak_test Nov 1, 2012


reset bucket properties test #81

jrwest added some commits Nov 2, 2012

@jrwest jrwest don't write tombstone if metadata dne
otherwise this could add to the amount of gossiped data instead of reducing it
@jrwest jrwest whitespace 467c935

jerith commented Nov 5, 2012

Awesome, thanks!

smn commented Nov 5, 2012


@slfritchie slfritchie was assigned Nov 13, 2012

@jrwest jrwest was assigned Nov 13, 2012

@jrwest jrwest merged commit 467c935 into master Nov 13, 2012

1 check passed

default The Travis build passed

@jaredmorrow jaredmorrow pushed a commit that referenced this pull request Apr 21, 2013

Jared Morrow Merge pull request #248 from basho/klm-fix-bitcask-startup-dir-test
Properly sort results for comparison in bitcask startup_dir_test.

@seancribbs seancribbs deleted the gh197-reset-bucket-props branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment