Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

rework coverage fsm timeouts. #302

Merged
merged 2 commits into from May 24, 2013

Conversation

Projects
None yet
3 participants
Contributor

evanmcc commented Apr 18, 2013

Current coverage fsm timeouts arent' consistent with the way other timeouts in riak work. This change makes it so they're bounded by the total time given by the init functions, rather than applying their timeout to their waiting phases, which could be unbounded if there are multiple calls to waiting_results.

Current coverage fsm timeouts arent' consistent with the way other
timeouts in riak work.  This change makes it so they're bounded
by the total time given by the init functions, rather than applying
their timeout to their waiting phases, which could be unbounded
if there are multiple calls to waiting_results.

@evanmcc evanmcc referenced this pull request in basho/riak_test Apr 19, 2013

Merged

test for bucket and key listing timeouts #263

@ghost ghost assigned evanmcc Apr 19, 2013

Contributor

seancribbs commented May 2, 2013

I'm generally 👍 but there should be a review from another person, e.g. @jtuple @jrwest @engelsanchez @rzezeski

@ghost ghost assigned kellymclaughlin May 13, 2013

Contributor

kellymclaughlin commented May 24, 2013

+1 to merge

@ghost ghost assigned evanmcc May 24, 2013

Merge branch 'master' into pevm-coverage-timeout-refactor
Conflicts:
	src/riak_core_coverage_fsm.erl

evanmcc added a commit that referenced this pull request May 24, 2013

@evanmcc evanmcc merged commit 8a754d4 into master May 24, 2013

1 check passed

default The Travis CI build passed
Details

@seancribbs seancribbs deleted the pevm-coverage-timeout-refactor branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment