Support for `plan/2` and `process_results/3` funs for coverage fsm #305

merged 2 commits into from May 24, 2013


None yet
3 participants

russelldb commented Apr 25, 2013

Enables 2i pagination.

See basho/riak_kv#535 for more details

@ghost ghost assigned russelldb May 7, 2013

@ghost ghost assigned evanmcc and engelsanchez May 16, 2013

+exports(Function, Exports) ->
+ proplists:is_defined(Function, Exports).
+exports_arity(Function, Arity, Exports) ->

engelsanchez May 17, 2013


Probably simpler to just do lists:member(Arity, proplists:get_all_values(Function, Exports))

@@ -112,7 +112,9 @@ behaviour_info(_) ->
required_responses :: pos_integer(),
response_count=0 :: non_neg_integer(),
timeout :: timeout(),
- vnode_master :: atom()
+ vnode_master :: atom(),
+ plan_fun :: function(),

engelsanchez May 17, 2013


I learned something new here. I can't see function() in the list of built-in types, but it's obviously used in the OTP code and ours.


russelldb commented May 24, 2013

Addressed comment, it was a much better idea, I did it, thanks!


engelsanchez commented May 24, 2013

I'm done here. Tested along the other 2i pagination changes, looking good.

👍 💃 ⛵️

russelldb added a commit that referenced this pull request May 24, 2013

Merge pull request #305 from basho/pt29-2i-pagination
Support for `plan/2` and `process_results/3` funs for coverage fsm

@russelldb russelldb merged commit 0c8dd97 into master May 24, 2013

1 check passed

default The Travis CI build passed

@seancribbs seancribbs deleted the pt29-2i-pagination branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment