Permanently disable legacy gossip #323

Merged
merged 1 commit into from May 30, 2013

3 participants

@jtuple

This commit hardcodes all checks for legacy gossip to return false. This is the first step towards removing legacy gossip from riak_core entirely. A future commit will completely remove all relevant code as well as adjust the callsites that currently still call into these now hardcoded functions.

@jtuple jtuple Permanently disable legacy gossip
This commit hardcodes all checks for legacy gossip to return
false. This is the first step towards removing legacy gossip
from riak_core entirely. A future commit will completely remove
all relevant code as well as adjust the callsites that currently
still call into these now hardcoded functions.
d0ea731
@rzezeski

+1 to merge

  • Code compiles, eunit passes, EQC passes
  • The riak test basic-upgrade and staged-clustering pass
  • Lightly ran through areas that call legacy gossip, couldn't find anything that might be harmful.
  • Discussed PR with @jtuple for 30 minutes, as long as someone doesn't mix a 0.14.x and 1.x node in the same cluster we are fine.
@jrwest jrwest merged commit d0ea731 into master May 30, 2013

1 check passed

Details default The Travis CI build passed
@jrwest jrwest referenced this pull request Feb 6, 2014
@seancribbs seancribbs Correct case for missing clause related to ring resizing.
TODO: This seems like a real bug that should be addressed. Ask @jrwest
f4783bc
@seancribbs seancribbs deleted the jdb-disable-legacy-gossip branch Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment