Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix TCP mon to correctly spot nodes coming up. #352

Merged
merged 1 commit into from

3 participants

@jonmeredith
Owner

Corrected add_dist_conn argument order on nodeup event.

@jonmeredith jonmeredith Fix TCP mon to correctly spot nodes coming up.
Corrected add_dist_conn argument order on nodeup event.
af20e80
@metadave

travis failures, but eunit tests pass locally

module 'worker_pool_pulse'
module 'worker_pool_test'
  worker_pool_test: pool_test_...[1.201 s] ok
  worker_pool_test: pool_test_...[1.201 s] ok
  [done in 2.408 s]
=======================================================
  All 346 tests passed.

+1 as it matches the 1.3.2 code

@rzezeski

We are ignoring travis now and going by internal buildbot status, which passed this branch. +1 to merge.

@jonmeredith jonmeredith merged commit eea9d61 into 1.4

1 check failed

Details default The Travis CI build failed
@seancribbs seancribbs deleted the jdm-tcp-mon-add-dist-fix branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 30, 2013
  1. @jonmeredith

    Fix TCP mon to correctly spot nodes coming up.

    jonmeredith authored
    Corrected add_dist_conn argument order on nodeup event.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/riak_core_tcp_mon.erl
View
2  src/riak_core_tcp_mon.erl
@@ -206,7 +206,7 @@ handle_info({nodeup, Node, _InfoList}, State) ->
lager:error("Could not get dist for ~p\n~p\n", [Node, DistCtrl]),
{noreply, State};
Port ->
- {noreply, add_dist_conn(Port, Node, State)}
+ {noreply, add_dist_conn(Node, Port, State)}
end;
handle_info({nodedown, Node, _InfoList}, State) ->
Something went wrong with that request. Please try again.