Fix TCP mon to correctly spot nodes coming up. #352

Merged
merged 1 commit into from Jul 30, 2013

Conversation

Projects
None yet
3 participants
Contributor

jonmeredith commented Jul 30, 2013

Corrected add_dist_conn argument order on nodeup event.

@jonmeredith jonmeredith Fix TCP mon to correctly spot nodes coming up.
Corrected add_dist_conn argument order on nodeup event.
af20e80
Contributor

metadave commented Jul 30, 2013

travis failures, but eunit tests pass locally

module 'worker_pool_pulse'
module 'worker_pool_test'
  worker_pool_test: pool_test_...[1.201 s] ok
  worker_pool_test: pool_test_...[1.201 s] ok
  [done in 2.408 s]
=======================================================
  All 346 tests passed.

+1 as it matches the 1.3.2 code

Contributor

rzezeski commented Jul 30, 2013

We are ignoring travis now and going by internal buildbot status, which passed this branch. +1 to merge.

@jonmeredith jonmeredith added a commit that referenced this pull request Jul 30, 2013

@jonmeredith jonmeredith Merge pull request #352 from basho/jdm-tcp-mon-add-dist-fix
Fix TCP mon to correctly spot nodes coming up.
eea9d61

@jonmeredith jonmeredith merged commit eea9d61 into 1.4 Jul 30, 2013

1 check failed

default The Travis CI build failed
Details

seancribbs deleted the jdm-tcp-mon-add-dist-fix branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment