Add token management to Background manager. #361

Closed
wants to merge 38 commits into
from

Conversation

Projects
None yet
9 participants
@buddhisthead
Contributor

buddhisthead commented Aug 22, 2013

This is an initial stab at adding token management to the background manager.

Token manager is broken out to a separate gen_server.
Token calls are available in the background manager and proxied to the token manager server.
Changed enabled/disabled in BG manager to affect BOTH subsystems.
Renamed enable/disable for locks to enable_lock/disable_lock to match API for tokens: enable_tokens/disable_tokens

Comments are welcomed.

@jrwest

This comment has been minimized.

Show comment Hide comment
@jrwest

jrwest Aug 23, 2013

Contributor

Re: proxying through bg mgr module, i wonder if it would just be better to pull bolth APIs into third module instead. Thoughts?

Contributor

jrwest commented Aug 23, 2013

Re: proxying through bg mgr module, i wonder if it would just be better to pull bolth APIs into third module instead. Thoughts?

@buddhisthead

This comment has been minimized.

Show comment Hide comment
@buddhisthead

buddhisthead Aug 23, 2013

Contributor

Yeah, I was going to suggest that we extract the lock manager to it's own module. And proxy both. Would make bg module clean and more of a one-stop-shopping for all BG work and monitoring.

Contributor

buddhisthead commented Aug 23, 2013

Yeah, I was going to suggest that we extract the lock manager to it's own module. And proxy both. Would make bg module clean and more of a one-stop-shopping for all BG work and monitoring.

@buddhisthead

This comment has been minimized.

Show comment Hide comment
@buddhisthead

buddhisthead Aug 23, 2013

Contributor

@jrwest Actually, it occurs to me no that I didn't see your EQC tests in your branch. Did you already merge another branch with those? I might need to rebase this PR.

Contributor

buddhisthead commented Aug 23, 2013

@jrwest Actually, it occurs to me no that I didn't see your EQC tests in your branch. Did you already merge another branch with those? I might need to rebase this PR.

@jrwest

This comment has been minimized.

Show comment Hide comment
@jrwest

jrwest Aug 23, 2013

Contributor

@buddhisthead the EQC test isn't included because it needs to be rewritten to use eqc_temporal. What I originally had can be found here: https://gist.github.com/jrwest/c543a4e57e9edf5ce5fe#file-riak_core_bg_manager_eqc-erl

Contributor

jrwest commented Aug 23, 2013

@buddhisthead the EQC test isn't included because it needs to be rewritten to use eqc_temporal. What I originally had can be found here: https://gist.github.com/jrwest/c543a4e57e9edf5ce5fe#file-riak_core_bg_manager_eqc-erl

@slfritchie

This comment has been minimized.

Show comment Hide comment
@slfritchie

slfritchie Dec 12, 2013

Contributor

Chris: I'm in a fit of PR review & shepherding. When your background manager work has finished review & merged, would you mind taking care of the PRs and issues associated with it (such as this and #364 and others?) and tidy them up? Many thanks in advance.

Contributor

slfritchie commented Dec 12, 2013

Chris: I'm in a fit of PR review & shepherding. When your background manager work has finished review & merged, would you mind taking care of the PRs and issues associated with it (such as this and #364 and others?) and tidy them up? Many thanks in advance.

@buddhisthead

This comment has been minimized.

Show comment Hide comment
@buddhisthead

buddhisthead Dec 12, 2013

Contributor

@slfritchie Absolutely.

Contributor

buddhisthead commented Dec 12, 2013

@slfritchie Absolutely.

@buddhisthead

This comment has been minimized.

Show comment Hide comment
@buddhisthead

buddhisthead Jan 2, 2014

Contributor

#484 replaced this one. And it has merged :-)

Contributor

buddhisthead commented Jan 2, 2014

#484 replaced this one. And it has merged :-)

@seancribbs seancribbs deleted the cet-bg-mgr-proto branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment