Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add callback annotations to riak_core_vnode #543

Merged
merged 1 commit into from Jun 3, 2014

Conversation

Projects
None yet
4 participants
Contributor

seancribbs commented Mar 3, 2014

A few concerns popped up when doing this:

  • The handoff_type() type I added based on the code in riak_core_vnode differs significantly from the similar type in riak_core_handoff.hrl. This should be addressed.
  • Based on code in riak_core_handoff_sender, the encode_handoff_item/2 callback seems to be called with a term shaped like {_, _} as the key. This should probably be generalized so as not to crash if a new type of vnode returns corrupted from the callback.
  • Although the comments in the module mention that handle_exit/3 is optional, it was included in the behaviour_info/1 function previously, so I added the callback annotation anyway.

@jrwest jrwest modified the milestones: 2.0.1, 2.0-RC Mar 24, 2014

Contributor

jrwest commented Mar 24, 2014

this should improve dialyzer output for other repositories and is technically testing, so moved to 2.0-RC milestone.

Contributor

kellymclaughlin commented May 29, 2014

These changes look good to me. I rebased this branch locally from latest develop and it's passing all tests, dialyzer, and xref so I think we should merge it.

One question about the concerns listed, is it worth opening issues for those and assigning maybe to the 2.1 milestone?

Contributor

kellymclaughlin commented on 74f88d3 May 29, 2014

+1

Contributor

borshop replied May 29, 2014

saw approval from kellymclaughlin
at 74f88d3

Contributor

borshop replied May 29, 2014

merging basho/riak_core/feature/sdc/vnode-callbacks = 74f88d3 into borshop-integration-543-feature/sdc/vnode-callbacks

Contributor

borshop replied May 29, 2014

basho/riak_core/feature/sdc/vnode-callbacks = 74f88d3 merged ok, testing candidate = 19ee957

Contributor

borshop replied Jun 3, 2014

fast-forwarding develop to borshop-integration-543-feature/sdc/vnode-callbacks = 19ee957

@kellymclaughlin kellymclaughlin self-assigned this May 29, 2014

borshop added a commit that referenced this pull request May 29, 2014

Merge pull request #543 from basho/feature/sdc/vnode-callbacks
Add callback annotations to riak_core_vnode

Reviewed-by: kellymclaughlin
Contributor

seancribbs commented Jun 3, 2014

@borshop merge

@borshop borshop merged commit 74f88d3 into develop Jun 3, 2014

1 check passed

default all tests passed
Details

@seancribbs seancribbs deleted the feature/sdc/vnode-callbacks branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment