Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebar3 configuration for artifact #122

Closed
cmeiklejohn opened this issue Jul 5, 2017 · 8 comments
Closed

rebar3 configuration for artifact #122

cmeiklejohn opened this issue Jul 5, 2017 · 8 comments

Comments

@cmeiklejohn
Copy link
Contributor

I'm not sure what I'm missing, but I can't seem to get the artifacts building correctly for Riak Ensemble when building with Erlang 19 and rebar3.

===> Compiling riak_ensemble
_build/default/lib/riak_ensemble/src/riak_ensemble_util.erl:171: Warning: random:seed/3: the 'random' module is deprecated; use the 'rand' module instead
_build/default/lib/riak_ensemble/src/riak_ensemble_util.erl:179: Warning: random:uniform/1: the 'random' module is deprecated; use the 'rand' module instead

===> Linking priv/riak_ensemble_drv.so
===> Missing artifact c_src/riak_ensemble_clock.o
make: *** [devrel1] Error 1

Here's the override configuration:

  {override, riak_ensemble,
  [
     {artifacts, ["c_src/riak_ensemble_clock.o"]},
     {plugins, [pc]},
     {provider_hooks, [{post,
                         [{compile, {pc, compile}},
                          {clean, {pc, clean}}
                         ]}]},
      {erl_opts, [debug_info,
          warn_untyped_record,
          {parse_transform, lager_transform}]}
  ]},
@cmeiklejohn
Copy link
Contributor Author

cc: @marianoguerra @tsloughter

@cmeiklejohn
Copy link
Contributor Author

cc: @Licenser

@cmeiklejohn
Copy link
Contributor Author

I think the proper fix is this, but correct me if I'm wrong.

diff --git a/rebar.config b/rebar.config
index 4802e26..615a09e 100644
--- a/rebar.config
+++ b/rebar.config
@@ -60,7 +60,7 @@
   },
   {override, riak_ensemble,
   [
-     {artifacts, ["c_src/riak_ensemble_clock.o"]},
+     {artifacts, ["priv/riak_ensemble_drv.so"]},
      {plugins, [pc]},
      {provider_hooks, [{post,
                          [{compile, {pc, compile}},

@marianoguerra
Copy link

looks like it's correct, if my memory serves me well

@Licenser
Copy link

Licenser commented Jul 5, 2017

I think that is more important for @tsloughter he maintains the package :)

@cmeiklejohn
Copy link
Contributor Author

Opened a PR for @marianoguerra's templates.

@cmeiklejohn
Copy link
Contributor Author

@marianoguerra
Copy link

merged in my repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants