Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bz950 no progress on console #6

Merged
4 commits merged into from Dec 28, 2010

Conversation

Projects
None yet
2 participants
Contributor

slfritchie commented Dec 23, 2010

Reviewer: anyone. The commit log has all the stuff you'd need to know. Fixing the 950 bug/regression that Dizzy mentioned, then refactor & add Eunit tests & some Edoc.

slfritchie added some commits Dec 23, 2010

@slfritchie slfritchie Bug 950: riak_err sends progress reports to console
More closely mimic default SASL tty logger behavior: SASL progress
reports are not written to the tty/console.

Added a new environment config knob for the riak_err app,
console_error_type, to provide basic error level filtering
for the tty/console-mimicing behavior: 'all' (the default)
for all non-SASL-progress reports or 'error' for error-severity
non-SASL-progress reports.
0435a7b
@slfritchie slfritchie Bug 950: refactoring, EUnit tests, new config knob
Refactored the code so that it's possible to export a couple of
useful functions, format_event/3 and limited_fmt/4.  The refactoring
also made Eunit tests for the formatting much easier to write.

See the Edoc at the head of riak_err_app.erl for descriptions of
console_error_type and console_sasl_reports.
7f2a00d
Contributor

dizzyd commented on src/riak_err_handler.erl in 0435a7b Dec 28, 2010

Why is the atom 'x' passed as an argument to should_log_it?

Contributor

dizzyd commented on src/riak_err_handler.erl in 0435a7b Dec 28, 2010

Would to_integer (ala list_to_integer) be a more "common" name?

Contributor

dizzyd commented Dec 28, 2010

+1 on this commit. My comments don't have to be addressed to merge this, I think.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment