Resolve all outstanding dialyzer warnings. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: riak_jmx_monitor.erl:96: Expression produces a value of type string(), but this value is unmatched riak_jmx_monitor.erl:101: Expression produces a value of type string(), but this value is unmatched
Resolves dialyzer warnings about missing functions exported from kv and core.
Fix guard and check for port, and not pid.
|
Assigning @joedevivo. |
|
looks good. |
|
We decided to leave the dialyzer ones separate with each one addressing a specific issue outlined in the commit message. |
cmeiklejohn
added a commit
that referenced
this pull request
May 9, 2014
Resolve all outstanding dialyzer warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve all outstanding dialyzer warnings, and now we can enable bors.