Resolve 2I timeout error from case clause #379

Merged
merged 1 commit into from Aug 22, 2012

Conversation

Projects
None yet
3 participants
Contributor

seancribbs commented Aug 6, 2012

Neither the HTTP nor the PB interfaces match the {error, timeout, Acc} return value of riak_client:wait_for_query_results/3 that results from a receive timeout. This case is difficult to reach except in the case of a heavily loaded cluster, which is why it has not been hit before.

This changes the return value on timeout to be simply {error, timeout}. Partial results from a timed out request could be of dubious value and correctness, so the simplest solution is not to return them.

seancribbs was assigned Aug 15, 2012

reiddraper was assigned Aug 22, 2012

Contributor

reiddraper commented Aug 22, 2012

Welp, I'm having all sorts of fun running the kv eunit tests, but this looks good to me. +1

seancribbs was assigned Aug 22, 2012

seancribbs merged commit 917fc02 into 1.2 Aug 22, 2012

This pull request fails (merged 8155934 into 5a4071c).

seancribbs deleted the sdc-2i-timeout-case-clause branch Apr 1, 2015

seancribbs removed their assignment May 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment