Remove Luke usage #433

Merged
merged 2 commits into from Nov 14, 2012

Projects

None yet

4 participants

@beerriot
Contributor

riak_pipe powers MapReduce queries now

Bryan Fink remove luke usage
riak_pipe powers MapReduce queries now
28c6bdf
@beerriot beerriot was assigned Nov 12, 2012
@beerriot
Contributor

In reviewing other PRs, I was reminded that we can also remove the "mget" call from riak_kv_vnode. Luke-based MapReduce was the only thing that used it.

@slfritchie
Contributor

Bryan, if you'd create a new issue to remove the mget call, I'm fine with that.

No new failing EUnit failures, no significant changes to Dialyzer warnings. +1 to merge all 5 related PRs, many thanks!

@seancribbs
Contributor

finksplosion

@kellymclaughlin
Contributor

Can this be removed as part of this pr also?

Bryan Fink remove 'legacy' from mapred_system capability
Nodes without Luke are unable to provide 'legacy' MapReduce. They can
only provide 'pipe' MapReduce.
cb88551
@beerriot
Contributor

Good catch, @kellymclaughlin! Unfortunately, it can't be remove the {riak_kv, mapred_system} capability just yet. If we remove it, and then there is a cluster membership change before all nodes are running the version of Riak with it removed, a renegotiation will flip those old nodes back to legacy, which will then cause them to fail at MapReduce queries.

However, new nodes also shouldn't lie about what they're capable of. I've just pushed a patch to remove legacy from what new nodes announce. Eventually we'll get all nodes announcing pipe by default, and then we can remove it.

@kellymclaughlin
Contributor

Great point, I need to do that for my legacy keylisting pr as well.

@kellymclaughlin
Contributor

+1 to merge after last commit

@beerriot beerriot merged commit cb88551 into master Nov 14, 2012

1 check passed

default The Travis build passed
Details
@beerriot beerriot pushed a commit that referenced this pull request Nov 14, 2012
Bryan Fink remove the unused 'mget' command from riak_kv_vnode
As of basho/riak_kv#433 (removal of luke), nothing uses this command.
b69961d
@beerriot beerriot pushed a commit that referenced this pull request Nov 15, 2012
Bryan Fink undo resurrection of ClientType argument to keys/buckets fsm
It was removed when luke was removed in PR #433.
2852659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment