Remove Link headers from bucket and key lists #491

Merged
merged 4 commits into from Mar 1, 2013

2 participants

@seancribbs

While webmachine/mochiweb only accepts headers up to 8KB in size, it has no problem producing huge headers. However, many clients cannot handle large headers. Since the same information is produced in the body of these requests anyway, we have no need to produce Link headers as well. If we want to really use HATEOAS, other things need to be reconsidered. Since we don't really have HATEOAS, let's not pretend anymore.

This also adds some ignores for EQC artifacts.

seancribbs added some commits Feb 20, 2013
@seancribbs seancribbs Ignore EQC stuffs. 3fc34a0
@seancribbs seancribbs Remove Link headers from bucket and key lists.
While webmachine/mochiweb only accepts headers up to 8KB in size, it
has no problem producing huge headers. However, many clients cannot
handle large headers. Since the same information is produced in the
body of these requests anyway, we have no need to produce Link headers
as well. If we want to really use HATEOAS, other things need to be
reconsidered. Since we don't really have HATEOAS, let's not pretend
anymore.
1031fb5
@seancribbs seancribbs was assigned Feb 20, 2013
@russelldb russelldb was assigned Mar 1, 2013
@russelldb russelldb and 1 other commented on an outdated diff Mar 1, 2013
src/riak_kv_wm_keylist.erl
@@ -131,13 +131,10 @@ encodings_provided(RD, Ctx) ->
%% if the keys are included in the JSON object. The Link header
@russelldb
Basho Technologies member
russelldb added a line comment Mar 1, 2013

Shouldn't these comments be changed / expunged?

@seancribbs
seancribbs added a line comment Mar 1, 2013

Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@russelldb
Basho Technologies member

I never knew about this 'feature', madness.

Definitely +1 on removing the links. Technically changes the API…does that matter? We seem to do that anyway every release(I mean, we're not very semver).

WFM +1 after that comments comment has been addressed.

@seancribbs seancribbs was assigned Mar 1, 2013
@seancribbs seancribbs merged commit 3dffe18 into master Mar 1, 2013
@seancribbs seancribbs deleted the sdc-etoomanylinks branch Mar 1, 2013
@seancribbs seancribbs removed their assignment May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment