Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

kv_wm_utils expects ?MD_DELETED to be "true" not 'true' #532

Merged
merged 1 commit into from

2 participants

@jrwest

minimal possible fix. long term these types of things should be encapsulated
in riak_object

found here (includes steps to recreate): #520 (comment) (Note: to recreate issue you must create a tombstone sibling, not just a sibling)

Java code that exposes issue: https://gist.github.com/broach/57ce9237ec32b47d8897

cc/ @broach @seancribbs

@jrwest jrwest kv_wm_utils expects ?MD_DELETED to be "true" not 'true'
minimal possible fix. long term these types of things should be encapsulated
in riak_object
419cf8b
@broach broach referenced this pull request from a commit
@broach broach Reverted to checking for string instead of atom
The change in #532 makes this a string again ("true")
f577586
@seancribbs seancribbs was assigned
@seancribbs
Owner

:+1: This fixes the problem.

@jrwest jrwest merged commit 561be08 into from
@jrwest jrwest deleted the branch
@broach broach referenced this pull request from a commit
@broach broach Reverted to checking for string instead of atom
The change in #532 makes this a string again ("true")
c30a3c7
@broach broach referenced this pull request from a commit
@broach broach Reverted to checking for string instead of atom
The change in #532 makes this a string again ("true")
c836bca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 19, 2013
  1. @jrwest

    kv_wm_utils expects ?MD_DELETED to be "true" not 'true'

    jrwest authored
    minimal possible fix. long term these types of things should be encapsulated
    in riak_object
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/riak_object.erl
View
2  src/riak_object.erl
@@ -638,7 +638,7 @@ sib_of_binary(<<ValLen:32/integer, ValBin:ValLen/binary, MetaLen:32/integer, Met
{#r_content{metadata=MD, value=decode_maybe_binary(ValBin)}, Rest}.
deleted_meta(<<1>>, MDList) ->
- [{?MD_DELETED, true} | MDList];
+ [{?MD_DELETED, "true"} | MDList];
deleted_meta(_, MDList) ->
MDList.
Something went wrong with that request. Please try again.